identified a falsy bug in VirtualFile.php

msievenpiper · msievenpiper · commit e1ef86631982 · 2026-06-05T12:06:06.000+01:00
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -13,7 +13,7 @@ jobs:
       fail-fast: true
       matrix:
         os: [ubuntu-latest]
-        php: [8.2, 8.1, 8.0, 7.4]
+        php: [8.4, 8.2, 8.1, 8.0, 7.4]
 
     name: P${{ matrix.php }} - ${{ matrix.stability }} - ${{ matrix.os }}
 
diff --git a/src/Support/VirtualFile.php b/src/Support/VirtualFile.php
@@ -18,7 +18,7 @@ public function __destruct()
 
     public function unlink()
     {
-        if (! strpos(dirname($this->path), sys_get_temp_dir())) {
+        if (strpos(dirname($this->path), sys_get_temp_dir()) === false) {
             return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public function __destruct()`
`18`	`18`
`19`	`19`	`public function unlink()`
`20`	`20`	`{`
`21`		`- if (! strpos(dirname($this->path), sys_get_temp_dir())) {`
	`21`	`+ if (strpos(dirname($this->path), sys_get_temp_dir()) === false) {`
`22`	`22`	`return;`
`23`	`23`	`}`
`24`	`24`