feat: Added Ingress SecurityContext and ServiceAccount#65
Conversation
There was a problem hiding this comment.
Please add:
service:
port: 7000
To avoid the following error during Helm install:
Error: INSTALLATION FAILED: template: opal/templates/ingress-client.yaml:40:30: executing "opal/templates/ingress-client.yaml" at <$.Values.service.port>: nil pointer evaluating interface {}.port
There was a problem hiding this comment.
Yes good catch. Sorry for that. I corrected it and point to client.opaPort
3eeb5d5 to
139852c
Compare
Signed-off-by: tomassatka <satka.tomas@gmail.com>
|
Hi, is there any follow-up to this PR? Having an ingress as well would be useful |
|
Any moves here? Having service account would be very useful. |
|
Hi @tomassatka — thanks a lot for this contribution, and thanks @fililand and @eduard-k1 for your interest in it! 🙏 This is a useful addition and we'd love to get it merged. Since it was opened, To get this mergeable:
Once that's done we'll re-review and get it merged. Thanks again for your patience! 🚀 |
Made few improvements