Skip to content

Fix(pubsub): Catch and log EventBroadcaster init errors #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dulifu0 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix(pubsub): Catch and log EventBroadcaster init errors #874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions packages/opal-server/opal_server/pubsub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,19 @@ def __init__(self, signer: JWTSigner, broadcaster_uri: str = None):
self.broadcaster = None
if broadcaster_uri is not None:
logger.info(f"Initializing broadcaster for server<->server communication")
self.broadcaster = EventBroadcaster(
broadcaster_uri,
notifier=self.notifier,
channel=opal_server_config.BROADCAST_CHANNEL_NAME,
)
try:
self.broadcaster = EventBroadcaster(
broadcaster_uri,
notifier=self.notifier,
channel=opal_server_config.BROADCAST_CHANNEL_NAME,
)
except Exception as e:
logger.error(
"Failed to initialize EventBroadcaster with uri: {broadcaster_uri}. Exception: {e}",
broadcaster_uri=broadcaster_uri,
e=e,
)
self.broadcaster = None
else:
logger.info("Pub/Sub broadcaster is off")

Expand Down