Skip to content

Commit 35fbb30

Browse files
zeevmoneyCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent d879a6d commit 35fbb30

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/main/java/io/permit/sdk/api/GroupsApi.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ public GroupRead assignUserToGroup(String userId, String groupInstanceKey, Strin
273273
/**
274274
* Remove a role from the group, all users in this group will lose this role.
275275
*
276-
* @param groupInstanceKey The key of the group to assign the user.
276+
* @param groupInstanceKey The key of the group to remove the role from.
277277
* @param groupAddRole The {@link GroupAddRole} object containing the assignment data.
278278
* @throws IOException If an I/O error occurs during the HTTP request.
279279
* @throws PermitApiError If the Permit API returns a response with an error status code.

src/main/java/io/permit/sdk/openapi/models/GroupAddRole.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public class GroupAddRole {
4747
@Expose
4848
public String resource;
4949
/**
50-
* ResoruceInstance
50+
* ResourceInstance
5151
* <p>
5252
* The resource instance key or id that the role belongs to.
5353
* (Required)

src/main/java/io/permit/sdk/openapi/models/GroupAssignUser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class GroupAssignUser {
3636

3737
/**
3838
*
39-
* @param groupInstanceKey
39+
4040
* @param tenant
4141
*/
4242
public GroupAssignUser(java.lang.String tenant) {

src/test/java/io/permit/sdk/endpoints/GroupsApiE2ETest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ void testGroupsApi() {
216216
assertFalse(foundRole);
217217
assertFalse(foundResource);
218218
assertFalse(foundResourceInstance);
219-
assertEquals(1, marketingGroup.assignedRoles.size());
219+
assertEquals(1, afterRemovingRole.assignedRoles.size());
220220

221221
// delete group
222222
logger.info("Delete group...");

0 commit comments

Comments
 (0)