Skip to content

Commit a73c03b

Browse files
authored
Apply suggestions from code review
1 parent 1a53d13 commit a73c03b

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

src/test/java/io/permit/sdk/endpoints/GroupsApiE2ETest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@ void testGroupsApi() {
115115
GroupRead marketingGroup = permit.api.groups.create(marketingData);
116116
assertNotNull(marketingGroup);
117117
assertNotNull(marketingGroup.groupResourceTypeKey);
118-
assertEquals(marketingGroup.groupResourceTypeKey, marketingData.groupResourceTypeKey);
119-
assertEquals(marketingGroup.groupTenant, marketingData.groupTenant);
120-
assertEquals(marketingGroup.groupInstanceKey, marketingData.groupInstanceKey);
118+
assertEquals(marketingData.groupResourceTypeKey, marketingGroup.groupResourceTypeKey);
119+
assertEquals(marketingData.groupTenant, marketingGroup.groupTenant);
120+
assertEquals(marketingData.groupInstanceKey, marketingGroup.groupInstanceKey);
121121
boolean foundMember = false;
122122
for (String role : marketingGroup.assignedRoles) {
123123
if (role.contains("member")) {
@@ -129,7 +129,7 @@ void testGroupsApi() {
129129

130130
logger.info("verify number of items increased by 1");
131131
GroupRead[] groups = permit.api.groups.list();
132-
assertEquals(groups.length, originalLength + 1);
132+
assertEquals(originalLength + 1, groups.length);
133133

134134
logger.info("verify can find new group in the new list");
135135
assertTrue(Arrays.stream(groups).map(r -> r.groupInstanceKey).collect(Collectors.toList()).toString().contains(marketingData.groupInstanceKey));
@@ -160,7 +160,7 @@ void testGroupsApi() {
160160

161161
logger.info("Adding user already in group");
162162
GroupRead afterAddingUserAgain = permit.api.groups.assignUserToGroup(bobData.key, GROUP_KEY, DEFAULT_TENANT);
163-
assertEquals(afterAddingUserAgain.users.size(), afterAddingUser.users.size());
163+
assertEquals(afterAddingUser.users.size(), afterAddingUserAgain.users.size());
164164
logger.info("Removing user from group");
165165
permit.api.groups.removeUserFromGroup(bobData.key, GROUP_KEY, DEFAULT_TENANT);
166166
GroupRead afterRemovingUser = permit.api.groups.get(GROUP_KEY);
@@ -228,7 +228,7 @@ void testGroupsApi() {
228228

229229
logger.info("Verify that again we have the initial number of groups");
230230
GroupRead[] groupsAfterDelete = permit.api.groups.list();
231-
assertEquals(groupsAfterDelete.length, originalLength);
231+
assertEquals(originalLength, groupsAfterDelete.length);
232232

233233
logger.info("Verify deleted groups cannot be deleted again");
234234
PermitApiError exception = assertThrows(PermitApiError.class, () -> {

0 commit comments

Comments
 (0)