Skip to content

Commit 59cbfe1

Browse files
committed
Align with shared
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
1 parent 71e2bb7 commit 59cbfe1

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

timeserieschart/src/QuerySettingsEditor.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import {
2525
Typography,
2626
useTheme,
2727
} from '@mui/material';
28-
import { FormatControls, FormatOptions, OptionsColorPicker, UnitSelector } from '@perses-dev/components';
28+
import { FormatControls, FormatOptions, OptionsColorPicker } from '@perses-dev/components';
2929
import React, { ReactElement, useEffect, useMemo, useRef, useState } from 'react';
3030
import DeleteIcon from 'mdi-material-ui/DeleteOutline';
3131
import AddIcon from 'mdi-material-ui/Plus';

timeserieschart/src/TimeSeriesChartPanel.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ import {
2121
useTimeRange,
2222
validateLegendSpec,
2323
legendValues,
24-
getQueryName,
2524
getCalculations,
2625
CalculationType,
26+
defaultQueryName,
2727
} from '@perses-dev/plugin-system';
2828
import {
2929
ChartInstance,
@@ -164,10 +164,6 @@ export function TimeSeriesChartPanel(props: TimeSeriesChartProps): ReactElement
164164
[annotationsWithData]
165165
);
166166

167-
const queryDefinitions = useMemo(() => {
168-
return queryResults.map((queryResult) => queryResult.definition);
169-
}, [queryResults]);
170-
171167
// Populate series data based on query results
172168
const {
173169
timeScale,
@@ -216,7 +212,7 @@ export function TimeSeriesChartPanel(props: TimeSeriesChartProps): ReactElement
216212
// queries & querySettings indices do not necessarily match, so we have to check the tail value of the $ref attribute
217213
let querySettings: QuerySettingsOptions | undefined;
218214
for (const item of querySettingsList ?? []) {
219-
if (item.queryName === getQueryName(queryDefinitions, result.definition)) {
215+
if (item.queryName === result.definition.spec.name || item.queryName === defaultQueryName(queryIndex)) {
220216
querySettings = item;
221217
// We don't break the loop here just in case there are multiple querySettings defined for the
222218
// same queryIndex, because in that case we want the last one to take precedence.

0 commit comments

Comments
 (0)