[ENHANCEMENT/BREAKINGCHANGE] TimeSeriesChart: add query name support for query settings#585
Open
Gladorme wants to merge 5 commits into
Open
[ENHANCEMENT/BREAKINGCHANGE] TimeSeriesChart: add query name support for query settings#585Gladorme wants to merge 5 commits into
Gladorme wants to merge 5 commits into
Conversation
3 tasks
Gladorme
changed the title
Gladorme
changed the title
Gladorme
changed the title
AntoineThebaud
changed the title
… for query settings Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Gladorme
force-pushed
the
named-queries
branch
2 times, most recently
from
cc39a7d to
f6d19a8
Compare
Gladorme
requested review from
a team,
AntoineThebaud and
Nexucis
as code owners
Nexucis
reviewed
Jun 26, 2026
| seriesIndex: 0, | ||
| querySettings: { | ||
| queryIndex: 0, | ||
| queryName: defaultQueryName(0), |
Member
There was a problem hiding this comment.
that's a massive breaking change. This will break every dashboard created without dashboard as code or by migrating from Grafana.
Member
Author
There was a problem hiding this comment.
Yeah, I will check if I can keep old data model
Member
Author
There was a problem hiding this comment.
Ok, I remember why I did this change. We can't keep index, because it will cause issue when re-ordering queries with query settings. I will rename queryName to queryIndex, but result will be the same => they will need to update queryIndex.
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on: perses/shared#69
Use query name or index for query settings.
Breaking change:
queryIndex renamed queryName
(int) => (string)
Screenshots
Queries:
Query settings:
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes