Skip to content

Commit 12bdeab

Browse files
committed
Add Firefox support
Signed-off-by: Andrew Stein <steinlink@gmail.com>
1 parent b0ee116 commit 12bdeab

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

rust/perspective-viewer/test/js/stability/leaks.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ test.describe("Memory Leaks", () => {
3939

4040
// From a helpful blog
4141
// https://media-codings.com/articles/automatically-detect-memory-leaks-with-puppeteer
42-
await page.evaluate(() => window.gc());
42+
await page.evaluate(() => window.gc?.());
4343
const heap1 = await page.evaluate(
4444
() => performance.memory.usedJSHeapSize,
4545
);
@@ -61,7 +61,7 @@ test.describe("Memory Leaks", () => {
6161
// TODO this is very generous memory allowance suggests we
6262
// leak ~0.1% per instance.
6363
// TODO: Not yet sure how to access window.gc() in Playwright
64-
await page.evaluate(() => window.gc());
64+
await page.evaluate(() => window.gc?.());
6565
const heap2 = await page.evaluate(
6666
() => performance.memory.usedJSHeapSize,
6767
);
@@ -84,7 +84,7 @@ test.describe("Memory Leaks", () => {
8484
await viewer.reset();
8585
}, viewer);
8686

87-
await page.evaluate(() => window.gc());
87+
await page.evaluate(() => window.gc?.());
8888
const heap1 = await page.evaluate(
8989
() => performance.memory.usedJSHeapSize,
9090
);
@@ -108,7 +108,7 @@ test.describe("Memory Leaks", () => {
108108
}, viewer);
109109
}
110110

111-
await page.evaluate(() => window.gc());
111+
await page.evaluate(() => window.gc?.());
112112
const heap2 = await page.evaluate(
113113
() => performance.memory.usedJSHeapSize,
114114
);
@@ -130,7 +130,7 @@ test.describe("Memory Leaks", () => {
130130
await viewer.reset();
131131
}, viewer);
132132

133-
await page.evaluate(() => window.gc());
133+
await page.evaluate(() => window.gc?.());
134134
const heap1 = await page.evaluate(
135135
() => performance.memory.usedJSHeapSize,
136136
);
@@ -144,7 +144,7 @@ test.describe("Memory Leaks", () => {
144144
}, viewer);
145145
}
146146

147-
await page.evaluate(() => window.gc());
147+
await page.evaluate(() => window.gc?.());
148148
const heap2 = await page.evaluate(
149149
() => performance.memory.usedJSHeapSize,
150150
);

tools/test/playwright.config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ const DEVICE_OPTIONS = {
7474
],
7575
},
7676
},
77+
Firefox: {},
7778
};
7879

7980
const BROWSER_PACKAGES = [

tools/test/results.tar.gz

163 KB
Binary file not shown.

0 commit comments

Comments
 (0)