Skip to content

Commit 18eb7b9

Browse files
committed
WIP
Signed-off-by: Andrew Stein <steinlink@gmail.com>
1 parent 5d65b0f commit 18eb7b9

2 files changed

Lines changed: 6 additions & 13 deletions

File tree

packages/viewer-charts/src/ts/worker/renderer.worker.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -279,13 +279,9 @@ export class WorkerRenderer {
279279
}
280280
}
281281
} catch (err) {
282-
// Any unexpected throw — proxy hiccup, chart-impl mutation
283-
// failure, RAF chain rejection — must not leak past the
284-
// outer fire-and-forget caller (`dispatch` does not await
285-
// this method). Surface to the worker console; the host's
286-
// pending promise still gets resolved via the `finally`
287-
// ack below so `draw()` can't deadlock on a renderer error.
288-
console.error("loadAndRender failed", err);
282+
if ((err + "").indexOf("View not found") === -1) {
283+
console.error("loadAndRender failed", err);
284+
}
289285
} finally {
290286
this.post({ kind: "loadAndRenderAck", msgId: msg.msgId });
291287
}

tools/test/src/js/snapshot-sync.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,11 @@ function remoteHasRef(
3333
token: string | undefined,
3434
): boolean {
3535
try {
36-
const args = ["ls-remote", "--heads"];
36+
const args: string[] = [];
3737
if (token) {
38-
args.push(
39-
"-c",
40-
`http.extraHeader=Authorization: Bearer ${token}`,
41-
);
38+
remoteUrl = remoteUrl.replace("https://", `https://${token}@`);
4239
}
43-
args.push(remoteUrl, ref);
40+
args.push("ls-remote", "--heads", remoteUrl, ref);
4441
const out = execFileSync("git", args, {
4542
stdio: ["ignore", "pipe", "pipe"],
4643
})

0 commit comments

Comments
 (0)