Merge pull request #3144 from perspective-dev/just-viewer-updates

Add presize API to `<perspective-viewer>`

Author: texodus

.github/actions/install-deps/action.yaml

@@ -164,6 +164,16 @@ runs:
               targets: aarch64-unknown-linux-gnu
               components: rust-src
 
+        # Did you see a CI error of the form:
+        #
+        #     error: failed to install component: 'clippy-preview-aarch64-unknown-linux-gnu',
+        #     detected conflict: 'bin/cargo-clippy'
+        #
+        # See https://github.com/rust-lang/rustup/issues/988#issuecomment-1820438467
+        - name: Stupid cargo hack
+          shell: bash
+          run: cargo version
+
         # # TODO doesn't work.
         # - name: Install LLVM 17
         #   if: ${{ inputs.cpp == 'true' }}

rust/perspective-client/src/rust/config/expressions.rs

@@ -251,7 +251,7 @@ impl Expressions {
 }
 
 #[doc(hidden)]
-#[derive(Serialize, Clone, Copy)]
+#[derive(Serialize, Clone, Copy, PartialEq)]
 pub struct CompletionItemSuggestion {
     pub label: &'static str,
     pub insert_text: &'static str,

rust/perspective-viewer/src/less/column-selector.less

@@ -210,6 +210,11 @@
             }
         }
 
+        span.expression-edit-button.disabled {
+            opacity: 0;
+            pointer-events: none;
+        }
+
         span.expression-delete-button {
             padding-left: 5px;
             margin-right: 8px;

rust/perspective-viewer/src/less/viewer.less

@@ -314,7 +314,9 @@
         &:before {
             display: inline-block;
             height: 20px;
+            min-height: 20px;
             width: 20px;
+            min-width: 20px;
             content: "";
             mask-size: cover;
             -webkit-mask-size: cover;
@@ -351,7 +353,9 @@
         &:before {
             display: inline-block;
             height: 20px;
+            min-height: 20px;
             width: 20px;
+            min-width: 20px;
             content: "";
             mask-size: cover;
             -webkit-mask-size: cover;