Skip to content

Commit a248b91

Browse files
authored
Merge pull request #3127 from perspective-dev/fix-sql-split-by
Fix `split_by` support for rollups in generic SQL
2 parents 93b36bb + 7e09c92 commit a248b91

9 files changed

Lines changed: 1385 additions & 544 deletions

File tree

rust/perspective-client/src/rust/virtual_server/data.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,7 @@ impl VirtualDataSlice {
204204
if name.starts_with("__ROW_PATH_") {
205205
let group_by_index: u32 = name[11..name.len() - 2].parse()?;
206206
let max_grouping_id = 2_i32.pow((self.0.group_by.len() as u32) - group_by_index) - 1;
207-
if grouping_id.map(|x| x as i32).unwrap_or(i32::MAX) < max_grouping_id
208-
|| !self.0.split_by.is_empty()
209-
{
207+
if grouping_id.map(|x| x as i32).unwrap_or(i32::MAX) < max_grouping_id {
210208
if !self.contains_key("__ROW_PATH__") {
211209
self.insert(
212210
"__ROW_PATH__".to_owned(),

0 commit comments

Comments
 (0)