Fix theme bugs and assorted small regressions

Signed-off-by: Andrew Stein <steinlink@gmail.com>

Author: texodus

packages/viewer-datagrid/src/css/regular_table.css

@@ -342,6 +342,7 @@ regular-table table tbody td {
 }
 
 regular-table table {
+    font-size: 1em;
     user-select: none;
     color: inherit;
     border-collapse: separate;

packages/workspace/src/themes/pro-dark.css

@@ -13,7 +13,7 @@
 perspective-workspace,
 perspective-workspace[theme="Pro Dark"],
 perspective-indicator[theme="Pro Dark"] {
-    --theme-name: "Pro Dark";
+    --psp-theme-name: "Pro Dark";
 }
 
 perspective-workspace perspective-viewer {
@@ -23,11 +23,11 @@ perspective-workspace perspective-viewer {
 
 perspective-workspace perspective-viewer.widget-maximize {
     --modal-panel--margin: -4px 0 -4px 0;
-    --status-bar--border-radius: 6px 0 0 0;
-    --main-column--margin: 3px 0 3px 3px;
-    --main-column--border: 1px solid var(--inactive--color);
-    --main-column--border-width: 1px 0px 1px 1px;
-    --main-column--border-radius: 6px 0 0 6px;
+    --psp-status-bar--border-radius: 6px 0 0 0;
+    --psp-main-column--margin: 3px 0 3px 3px;
+    --psp-main-column--border: 1px solid var(--psp-inactive--color);
+    --psp-main-column--border-width: 1px 0px 1px 1px;
+    --psp-main-column--border-radius: 6px 0 0 6px;
     --settings-button--margin: 10px 0 0 0;
 }
 
@@ -55,62 +55,62 @@ perspective-workspace {
     --menu-new--content: "description";
     --menu-newview--content: "file_copy";
 
-    --workspace-tabbar--border: 1px solid var(--inactive--color);
-    --workspace-tabbar--border-width: 0px 1px 1px 1px;
-    --workspace-tabbar--border-radius: 6px;
-    --workspace-tabbar--border-color: var(--inactive--color);
-    --workspace-tabbar-tab--border-width: 1px 1px 0px 1px;
+    --psp-workspace--tabbar--border: 1px solid var(--psp-inactive--color);
+    --psp-workspace--tabbar--border-width: 0px 1px 1px 1px;
+    --psp-workspace--tabbar--border-radius: 6px;
+    --psp-workspace--tabbar--border-color: var(--psp-inactive--color);
+    --psp-workspace--tabbar-tab--border-width: 1px 1px 0px 1px;
 
     /* Workspace */
-    --column-drag-handle--mask-image: url("../svg/drag-handle.svg");
-    --bookmarks--mask-image: url("../svg/bookmark-icon.svg");
+    --psp-icon--column-drag-handle--mask-image: url("../svg/drag-handle.svg");
+    --psp-icon--bookmarks--mask-image: url("../svg/bookmark-icon.svg");
 
     /* perspective-viewer-pro-dark--colors */
     background-color: #242526;
-    --workspace-split-panel-handle--background-color: #242526;
+    --psp-workspace--split-panel-handle--background-color: #242526;
     color: white;
-    --icon--color: white;
-    --active--color: #2770a9;
-    --error--color: #ff9485;
-    --inactive--color: #61656e;
-    --inactive--border-color: #4c505b;
-    --plugin--background: #242526;
-    --active--background: rgba(39, 113, 170, 0.5);
-    --expression--operator-color: #c5c9d0;
-    --expression--function-color: #22a0ce;
-    --expression--error-color: rgb(255, 136, 136);
-    --calendar--filter: invert(1);
-    --warning--color: #242526;
-    --warning--background: var(--icon--color);
+    --psp--color: white;
+    --psp-active--color: #2770a9;
+    --psp-error--color: #ff9485;
+    --psp-inactive--color: #61656e;
+    --psp-inactive--border-color: #4c505b;
+    --psp--background-color: #242526;
+    --psp-active--background: rgba(39, 113, 170, 0.5);
+    --psp-expression--operator--color: #c5c9d0;
+    --psp-expression--function--color: #22a0ce;
+    --psp-expression--error--color: rgb(255, 136, 136);
+    --psp-calendar--filter: invert(1);
+    --psp-warning--color: #242526;
+    --psp-warning--background: var(--psp--color);
 
-    --select-arrow--background-image: var(
-        --select-arrow-light--background-image
+    --psp-icon--select-arrow--mask-image: var(
+        --psp-icon--select-arrow-light--mask-image
     );
 
-    --select-arrow--hover--background-image: var(
-        --select-arrow-dark--background-image
+    --psp-icon--select-arrow-hover--mask-image: var(
+        --psp-icon--select-arrow-dark--mask-image
     );
 
     /* Syntax */
-    --code-editor-symbol--color: white;
-    --code-editor-literal--color: #7dc3f0;
-    --code-editor-operator--color: rgb(23, 166, 123);
-    --code-editor-comment--color: rgb(204, 120, 48);
-    --code-editor-column--color: #e18ee1;
+    --psp-code-editor--symbol--color: white;
+    --psp-code-editor--literal--color: #7dc3f0;
+    --psp-code-editor--operator--color: rgb(23, 166, 123);
+    --psp-code-editor--comment--color: rgb(204, 120, 48);
+    --psp-code-editor--column--color: #e18ee1;
 
     background-color: #000202;
     color: white;
     --workspace-tabbar--background-color: #242526;
     --workspace-secondary--color: #c5c9d0;
-    --workspace-tabbar--border: 1px solid var(--inactive--color);
-    --workspace-tabbar--border-width: 1px 1px 1px 1px;
-    --workspace-tabbar--border-radius: 6px;
-    --workspace-tabbar--border-color: var(--inactive--color);
-    --workspace-tabbar-tab--border-width: 1px 1px 0 1px;
+    --psp-workspace--tabbar--border: 1px solid var(--psp-inactive--color);
+    --psp-workspace--tabbar--border-width: 1px 1px 1px 1px;
+    --psp-workspace--tabbar--border-radius: 6px;
+    --psp-workspace--tabbar--border-color: var(--psp-inactive--color);
+    --psp-workspace--tabbar-tab--border-width: 1px 1px 0 1px;
 }
 
 perspective-viewer[theme="Pro Dark"].workspace-master-widget {
-    --plugin--background: #242526;
+    --psp--background-color: #242526;
 }
 
 perspective-workspace-menu {

packages/workspace/src/themes/pro.css

@@ -17,7 +17,7 @@
 perspective-workspace,
 perspective-workspace[theme="Pro Light"],
 perspective-indicator[theme="Pro Light"] {
-    --theme-name: "Pro Light";
+    --psp-theme-name: "Pro Light";
 }
 
 perspective-workspace {
@@ -43,50 +43,50 @@ perspective-workspace {
     --menu-close--content: "close";
     --menu-new--content: "description";
     --menu-newview--content: "file_copy";
-    --workspace-split-panel-handle--background-color: #f2f4f6;
+    --psp-workspace--split-panel-handle--background-color: #f2f4f6;
 
-    --workspace-tabbar--border: 1px solid var(--inactive--color);
-    --workspace-tabbar--border-width: 1px 1px 1px 1px;
-    --workspace-tabbar--border-radius: 6px;
-    --workspace-tabbar--border-color: var(--inactive--color);
-    --workspace-tabbar-tab--border-width: 1px 1px 0px 1px;
+    --psp-workspace--tabbar--border: 1px solid var(--psp-inactive--color);
+    --psp-workspace--tabbar--border-width: 1px 1px 1px 1px;
+    --psp-workspace--tabbar--border-radius: 6px;
+    --psp-workspace--tabbar--border-color: var(--psp-inactive--color);
+    --psp-workspace--tabbar-tab--border-width: 1px 1px 0px 1px;
 
     /* Workspace */
-    --column-drag-handle--mask-image: url("../svg/drag-handle.svg");
-    --bookmarks--mask-image: url("../svg/bookmark-icon.svg");
+    --psp-icon--column-drag-handle--mask-image: url("../svg/drag-handle.svg");
+    --psp-icon--bookmarks--mask-image: url("../svg/bookmark-icon.svg");
 
     /* perspective-viewer-pro--colors */
     color: #161616;
     background-color: #dadada;
-    --icon--color: #161616;
-    --inactive--color: #ababab;
-    --inactive--border-color: #dadada;
+    --psp--color: #161616;
+    --psp-inactive--color: #ababab;
+    --psp-inactive--border-color: #dadada;
 
-    --active--color: #2670a9;
-    --error--color: #ff471e;
-    --plugin--background: #ffffff;
-    --overflow-hint-icon--color: rgba(0, 0, 0, 0.2);
-    --select--background-color: none;
-    --warning--background: #042121;
-    --warning--color: #fdfffd;
+    --psp-active--color: #2670a9;
+    --psp-error--color: #ff471e;
+    --psp--background-color: #ffffff;
+    --psp-icon-overflow-hint--color: rgba(0, 0, 0, 0.2);
+    --psp-select--background-color: none;
+    --psp-warning--background: #042121;
+    --psp-warning--color: #fdfffd;
 
-    --select-arrow--background-image: var(
-        --select-arrow-dark--background-image
+    --psp-icon--select-arrow--mask-image: var(
+        --psp-icon--select-arrow-dark--mask-image
     );
 
-    --select-arrow--hover--background-image: var(
-        --select-arrow-light--background-image
+    --psp-icon--select-arrow-hover--mask-image: var(
+        --psp-icon--select-arrow-light--mask-image
     );
 
     /* TODO deprecate me */
-    --overflow-hint-icon--color: #fdfffd;
+    --psp-icon-overflow-hint--color: #fdfffd;
 }
 
 perspective-workspace perspective-viewer.widget-maximize {
     /* --modal-panel--margin: -4px 0 -4px 0; */
     --psp-status-bar--border-radius: 6px 0 0 0;
     --psp-main-column--margin: 3px 0 3px 3px;
-    --psp-main-column--border: 1px solid var(--inactive--color);
+    --psp-main-column--border: 1px solid var(--psp-inactive--color);
     --psp-main-column--border-width: 1px 0px 1px 1px;
     --psp-main-column--border-radius: 6px 0 0 6px;
     /* --settings-button--margin: 10px 0 0 0; */
@@ -99,7 +99,7 @@ perspective-workspace perspective-viewer {
 
 perspective-viewer[theme="Pro Light"].workspace-master-widget {
     background-color: #f2f4f6;
-    --plugin--background: #f2f4f6;
+    --psp--background-color: #f2f4f6;
     regular-table {
         td,
         th {
@@ -109,7 +109,7 @@ perspective-viewer[theme="Pro Light"].workspace-master-widget {
 }
 
 perspective-viewer {
-    --bookmarks--mask-image: url("../svg/bookmark-icon.svg");
+    --psp-icon--bookmarks--mask-image: url("../svg/bookmark-icon.svg");
 }
 
 perspective-workspace-menu {

rust/perspective-js/test/js/joins/inner_join.spec.ts

@@ -33,10 +33,10 @@ test.describe("Inner joins", function () {
 
         expect(json).toHaveLength(2);
 
-        view.delete();
-        joined.delete();
-        right.delete();
-        left.delete();
+        await view.delete();
+        await joined.delete();
+        await right.delete();
+        await left.delete();
     });
 
     test("joined table has correct schema", async function () {
@@ -56,9 +56,9 @@ test.describe("Inner joins", function () {
             y: "string",
         });
 
-        joined.delete();
-        right.delete();
-        left.delete();
+        await joined.delete();
+        await right.delete();
+        await left.delete();
     });
 
     test("joined table reacts to left table updates", async function () {
@@ -87,10 +87,10 @@ test.describe("Inner joins", function () {
             { id: 1, x: 99, y: "a" },
         ]);
 
-        view.delete();
-        joined.delete();
-        right.delete();
-        left.delete();
+        await view.delete();
+        await joined.delete();
+        await right.delete();
+        await left.delete();
     });
 
     test("joined table reacts to right table updates", async function () {
@@ -119,10 +119,10 @@ test.describe("Inner joins", function () {
             { id: 2, x: 20, y: "b" },
         ]);
 
-        view.delete();
-        joined.delete();
-        right.delete();
-        left.delete();
+        await view.delete();
+        await joined.delete();
+        await right.delete();
+        await left.delete();
     });
 
     test("joined table reacts to new matching rows", async function () {
@@ -142,10 +142,10 @@ test.describe("Inner joins", function () {
         expect(json).toHaveLength(1);
         expect(json).toEqual([{ id: 1, x: 10, y: "a" }]);
 
-        view.delete();
-        joined.delete();
-        right.delete();
-        left.delete();
+        await view.delete();
+        await joined.delete();
+        await right.delete();
+        await left.delete();
     });
 
     test("joined table supports views with group_by", async function () {
@@ -171,10 +171,10 @@ test.describe("Inner joins", function () {
         expect(json["x"]).toEqual([60, 30, 30]);
         expect(json["y"]).toEqual([600, 300, 300]);
 
-        view.delete();
-        joined.delete();
-        right.delete();
-        left.delete();
+        await view.delete();
+        await joined.delete();
+        await right.delete();
+        await left.delete();
     });
 
     test("inner joins two tables by name strings", async function () {
@@ -206,10 +206,10 @@ test.describe("Inner joins", function () {
 
         expect(json).toHaveLength(2);
 
-        view.delete();
-        joined.delete();
-        right.delete();
-        left.delete();
+        await view.delete();
+        await joined.delete();
+        await right.delete();
+        await left.delete();
     });
 
     test("inner joins with mixed Table and string args", async function () {
@@ -232,10 +232,10 @@ test.describe("Inner joins", function () {
 
         expect(json).toHaveLength(2);
 
-        view.delete();
-        joined.delete();
-        right.delete();
-        left.delete();
+        await view.delete();
+        await joined.delete();
+        await right.delete();
+        await left.delete();
     });
 
     test("rejects column name conflicts", async function () {
@@ -250,8 +250,8 @@ test.describe("Inner joins", function () {
         }
 
         expect(error).toBeDefined();
-        right.delete();
-        left.delete();
+        await right.delete();
+        await left.delete();
     });
 
     test("rejects updates on joined table", async function () {
@@ -269,8 +269,8 @@ test.describe("Inner joins", function () {
 
         expect(error).toBeDefined();
 
-        joined.delete();
-        right.delete();
-        left.delete();
+        await joined.delete();
+        await right.delete();
+        await left.delete();
     });
 });