"weighted mean" by a computed column does not work anymore (used to in 3.7.4)

[abalabin-bamfunds]

Bug Report

Steps to Reproduce:

Choosing aggregation "weighted mean" by a computed column used to work in 3.7.4 and does not in 4.3.0.

Can be reproduced using the Superstore example by adding column D1="Discount", choosing "weighted mean by D1" for Profit, and the debugger show this:

Uncaught (in promise) Error: Abort(): Could not get dtype for column `D1` as it does not exist in the schema.

Expected Result:

Should work

Actual Result:

Error as above

Environment:

• Win 11, psp 4.3.0, Edge

[texodus]

Please use the template when opening an Issue, specifically the part about providing a repro. I know you didn't invent an error message, but what is "obvious" to you can save us a lot of painful debugging time. Not only do we have test coverage for cases like this, here's my first attempt:

{
  "version": "4.4.0",
  "plugin": "Datagrid",
  "table": "superstore",
  "group_by": [
    "State"
  ],
  "expressions": {
    "D1": "\"Discount\""
  },
  "columns": [
    "Sales",
    "D1",
    "Discount"
  ],
  "aggregates": {
    "Sales": [
      "weighted mean",
      [
        "D1"
      ]
    ]
  }
}

[abalabin-bamfunds]

If I take your example and remove the D1 column from the screen the issue reproduces. If you take the below and paste it in no error message is logged but nothing is computed either. Flipping by which column mean is done to something else and back brings the error message back.

{
  "version": "4.4.0",
  "columns_config": {},
  "plugin": "Datagrid",
  "plugin_config": {},
  "settings": true,
  "table": "superstore",
  "theme": "Pro Light",
  "title": "Sales Report 2",
  "group_by": [
    "State"
  ],
  "split_by": [
    "Category",
    "Sub-Category"
  ],
  "sort": [],
  "filter": [],
  "group_rollup_mode": "rollup",
  "expressions": {
    "D1": "\"Discount\""
  },
  "columns": [
    "Sales",
    "Discount"
  ],
  "aggregates": {
    "Sales": [
      "weighted mean",
      [
        "D1"
      ]
    ]
  }
}

[texodus]

Thanks, I've added a fix for this in #3161.

This bug was present in 3.7.4 (and previous since 1.6.2), so probably not the issue you're experiencing; since there's no repro for this case, I'm going to close this issue regardless.

If you take the below and paste it in no error message is logged but nothing is computed either.

The debug panel doesn't apply invalid configs, the validation error box is subtle (a red X in the top left corner).