Skip to content

Add Firefox support #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
texodus wants to merge 1 commit into from
Closed

Add Firefox support #3142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions rust/perspective-viewer/test/js/stability/leaks.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ test.describe("Memory Leaks", () => {

// From a helpful blog
// https://media-codings.com/articles/automatically-detect-memory-leaks-with-puppeteer
await page.evaluate(() => window.gc());
await page.evaluate(() => window.gc?.());
const heap1 = await page.evaluate(
() => performance.memory.usedJSHeapSize,
);
Expand All @@ -61,7 +61,7 @@ test.describe("Memory Leaks", () => {
// TODO this is very generous memory allowance suggests we
// leak ~0.1% per instance.
// TODO: Not yet sure how to access window.gc() in Playwright
await page.evaluate(() => window.gc());
await page.evaluate(() => window.gc?.());
const heap2 = await page.evaluate(
() => performance.memory.usedJSHeapSize,
);
Expand All @@ -84,7 +84,7 @@ test.describe("Memory Leaks", () => {
await viewer.reset();
}, viewer);

await page.evaluate(() => window.gc());
await page.evaluate(() => window.gc?.());
const heap1 = await page.evaluate(
() => performance.memory.usedJSHeapSize,
);
Expand All @@ -108,7 +108,7 @@ test.describe("Memory Leaks", () => {
}, viewer);
}

await page.evaluate(() => window.gc());
await page.evaluate(() => window.gc?.());
const heap2 = await page.evaluate(
() => performance.memory.usedJSHeapSize,
);
Expand All @@ -130,7 +130,7 @@ test.describe("Memory Leaks", () => {
await viewer.reset();
}, viewer);

await page.evaluate(() => window.gc());
await page.evaluate(() => window.gc?.());
const heap1 = await page.evaluate(
() => performance.memory.usedJSHeapSize,
);
Expand All @@ -144,7 +144,7 @@ test.describe("Memory Leaks", () => {
}, viewer);
}

await page.evaluate(() => window.gc());
await page.evaluate(() => window.gc?.());
const heap2 = await page.evaluate(
() => performance.memory.usedJSHeapSize,
);
Expand Down
1 change: 1 addition & 0 deletions tools/test/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ const DEVICE_OPTIONS = {
],
},
},
Firefox: {},
};

const BROWSER_PACKAGES = [
Expand Down
Binary file modified tools/test/results.tar.gz
View file
Open in desktop
Binary file not shown.
Loading