Batch repro variants + real dbatools test for #2829

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: nohwnd

.github/workflows/repro-2829.yml

@@ -7,13 +7,13 @@ on:
   workflow_dispatch:
 
 jobs:
-  repro:
+  synthetic:
     runs-on: windows-2022
     strategy:
       fail-fast: false
       matrix:
         pester: ['5.7.1', '6.0.0-rc1', '6.0.0-rc2', '6.0.0-rc3', '6.0.0-rc4']
-    name: Pester ${{ matrix.pester }}
+    name: synthetic ${{ matrix.pester }}
     steps:
       - uses: actions/checkout@v4
 
@@ -32,14 +32,63 @@ jobs:
           if (-not (Test-Path $psd1)) { throw "psd1 not found at $psd1" }
           "PESTER_PSD1=$psd1" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8
 
-      - name: Run repro on Windows PowerShell 5.1 (Desktop)
+      - name: Variants on Windows PowerShell 5.1 (Desktop)
         shell: powershell
         continue-on-error: true
         run: |
-          powershell -NoProfile -ExecutionPolicy Bypass -File .repro2829\run.ps1 -PesterPsd1 "$env:PESTER_PSD1" -Repro ".repro2829\repro.ps1"
+          powershell -NoProfile -ExecutionPolicy Bypass -File .repro2829\variants.ps1 -PesterPsd1 "$env:PESTER_PSD1"
 
-      - name: Run repro on PowerShell 7 (Core)
+      - name: Variants on PowerShell 7 (Core)
         shell: pwsh
         continue-on-error: true
         run: |
-          pwsh -NoProfile -File .repro2829/run.ps1 -PesterPsd1 "$env:PESTER_PSD1" -Repro ".repro2829/repro.ps1"
+          pwsh -NoProfile -File .repro2829/variants.ps1 -PesterPsd1 "$env:PESTER_PSD1"
+
+  real:
+    runs-on: windows-2022
+    strategy:
+      fail-fast: false
+      matrix:
+        pester: ['5.7.1', '6.0.0-rc4']
+    name: real dbatools ${{ matrix.pester }}
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Save Pester ${{ matrix.pester }} and dbatools.library
+        shell: pwsh
+        run: |
+          [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
+          Get-PackageProvider -Name NuGet -ForceBootstrap | Out-Null
+
+          $ver = '${{ matrix.pester }}'
+          $folder = ($ver -split '-')[0]
+          $dest = Join-Path $env:RUNNER_TEMP "pmods_$ver"
+          New-Item -ItemType Directory -Path $dest -Force | Out-Null
+          $pre = $ver -like '*-*'
+          Save-Module -Name Pester -RequiredVersion $ver -AllowPrerelease:$pre -Path $dest -Repository PSGallery -Force
+          $psd1 = Join-Path $dest "Pester\$folder\Pester.psd1"
+          if (-not (Test-Path $psd1)) { throw "psd1 not found at $psd1" }
+          "PESTER_PSD1=$psd1" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8
+
+          $libdest = Join-Path $env:RUNNER_TEMP "libmods"
+          New-Item -ItemType Directory -Path $libdest -Force | Out-Null
+          Save-Module -Name dbatools.library -RequiredVersion 2025.12.28 -Path $libdest -Repository PSGallery -Force
+          "LIBMODS=$libdest" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8
+
+      - name: Clone dbatools (PR 10405 head, commit 15c3981)
+        shell: pwsh
+        run: |
+          git clone --branch pester-6-rc --depth 1 https://github.com/nohwnd/dbatools.git "$env:RUNNER_TEMP\dbatools_src"
+          "DBATOOLS_SRC=$env:RUNNER_TEMP\dbatools_src" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8
+
+      - name: Real negative test on Windows PowerShell 5.1 (Desktop)
+        shell: powershell
+        continue-on-error: true
+        run: |
+          powershell -NoProfile -ExecutionPolicy Bypass -File .repro2829\real-run.ps1 -PesterPsd1 "$env:PESTER_PSD1" -DbatoolsPath "$env:DBATOOLS_SRC" -LibraryModulePath "$env:LIBMODS"
+
+      - name: Real negative test on PowerShell 7 (Core)
+        shell: pwsh
+        continue-on-error: true
+        run: |
+          pwsh -NoProfile -File .repro2829/real-run.ps1 -PesterPsd1 "$env:PESTER_PSD1" -DbatoolsPath "$env:DBATOOLS_SRC" -LibraryModulePath "$env:LIBMODS"

.repro2829/real-run.ps1

@@ -0,0 +1,53 @@
+#
+# Definitive reproduction for pester/Pester#2829: run the real dbatools negative test
+# ("fails when update execution has failed") the same way tests/appveyor.pester.ps1 does.
+# Prints REPRO_RESULT_REAL with a PASS/FAIL verdict and whether the failure looks like a
+# mock-miss (the real Invoke-Program ran and hit WinRM).
+#
+[CmdletBinding()]
+param(
+    [Parameter(Mandatory)][string] $PesterPsd1,
+    [Parameter(Mandatory)][string] $DbatoolsPath,
+    [string] $LibraryModulePath
+)
+$ErrorActionPreference = 'Stop'
+
+if ($LibraryModulePath) {
+    $env:PSModulePath = $LibraryModulePath + [IO.Path]::PathSeparator + $env:PSModulePath
+}
+
+Get-Module Pester, dbatools, dbatools.library | Remove-Module -Force -ErrorAction SilentlyContinue
+Import-Module $PesterPsd1 -Force
+$pesterMod = Get-Module Pester
+$label = "$($PSVersionTable.PSEdition)/$($PSVersionTable.PSVersion) Pester $($pesterMod.Version) $($pesterMod.PrivateData.PSData.Prerelease)".Trim()
+Write-Host "== REAL $label =="
+
+# Import dbatools exactly like tests/appveyor.pester.ps1 (dot-sourced module load).
+$global:dbatools_dotsourcemodule = $true
+Import-Module (Join-Path $DbatoolsPath 'dbatools.psm1') -Force
+Write-Host "dbatools imported: $((Get-Module dbatools).Version); nested: $((Get-Module dbatools).NestedModules.Name -join ',')"
+
+# The test file's param default is $TestConfig.Defaults.
+try { $global:TestConfig = Get-TestConfig }
+catch {
+    try { $global:TestConfig = & (Get-Module dbatools) { Get-TestConfig } }
+    catch { $global:TestConfig = $null }
+}
+
+$testFile = Join-Path $DbatoolsPath 'tests/Install-DbaInstance.Tests.ps1'
+$cfg = New-PesterConfiguration
+$cfg.Run.Path = $testFile
+$cfg.Run.PassThru = $true
+$cfg.Filter.FullName = '*fails when update execution has failed*'
+$cfg.Output.Verbosity = 'Detailed'
+$r = Invoke-Pester -Configuration $cfg
+
+$failed = $r.FailedCount
+$errs = ''
+if ($failed -gt 0) {
+    $errs = ($r.Tests | Where-Object Result -eq 'Failed' | ForEach-Object { "$($_.ErrorRecord)" }) -join ' || '
+}
+$mockMiss = [bool]($errs -match 'WinRM|remote server|cannot be resolved|Connecting to remote|Access is denied|exit code (?!12345)')
+$verdict = if ($failed -eq 0) { 'PASS' } else { 'FAIL' }
+Write-Host ("REPRO_RESULT_REAL :: {0} :: mockmiss={1} :: {2} :: failed={3} :: {4}" -f $verdict, $mockMiss, $label, $failed, $errs)
+exit 0