Fix #2678: Suppress Get-CimInstance access denied error#2695
Merged
Conversation
Member
Author
|
tests |
Copilot-generated fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nohwnd
force-pushed
the
fix-2678-ciminstance
branch
from
f34f9c8 to
5d6abc8
Compare
Member
Author
|
🤖 Tests added in latest push — verifies Get-RunTimeEnvironment returns expected keys without throwing. |
The previous tests were sanity smoke tests that passed even on the buggy code (they only verified the function returned the expected hashtable shape). Add a Windows-only test that stubs SafeCommands[Get-CimInstance] to return $null (simulating access denied with -ErrorAction Ignore) and asserts the Unknown / 0.0.0.0 fallback is applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2678
Added
-ErrorAction IgnoretoGet-CimInstanceandGet-WmiObjectcalls inGet-RunTimeEnvironmentwith null fallback when not running as Administrator.Copilot-generated fix.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com