chore: adjusts existing tests

Author: nunomaduro

src/Playwright/Locator.php

@@ -7,7 +7,9 @@
 use Generator;
 use Pest\Browser\Playwright\Concerns\InteractsWithPlaywright;
 use Pest\Browser\Support\Selector;
+use PHPUnit\Framework\ExpectationFailedException;
 use RuntimeException;
+use WebSocket\TimeoutException;
 
 /**
  * @internal
@@ -31,6 +33,8 @@ public function __construct(
      */
     public function isVisible(): bool
     {
+        $this->waitFor();
+
         $response = $this->sendMessage('isVisible');
 
         return $this->processBooleanResponse($response);
@@ -41,6 +45,8 @@ public function isVisible(): bool
      */
     public function isChecked(): bool
     {
+        $this->waitFor();
+
         $response = $this->sendMessage('isChecked');
 
         return $this->processBooleanResponse($response);
@@ -51,6 +57,8 @@ public function isChecked(): bool
      */
     public function isEnabled(): bool
     {
+        $this->waitFor();
+
         $response = $this->sendMessage('isEnabled');
 
         return $this->processBooleanResponse($response);
@@ -61,22 +69,32 @@ public function isEnabled(): bool
      */
     public function isDisabled(): bool
     {
-        return ! $this->isEnabled();
+        $this->waitFor();
+
+        $response = $this->sendMessage('isDisabled');
+
+        return $this->processBooleanResponse($response);
     }
 
     /**
      * Check if element matching the locator is hidden.
      */
     public function isHidden(): bool
     {
-        return ! $this->isVisible();
+        $this->waitFor(['state' => 'hidden']);
+
+        $response = $this->sendMessage('isHidden');
+
+        return $this->processBooleanResponse($response);
     }
 
     /**
      * Check if element matching the locator is editable.
      */
     public function isEditable(): bool
     {
+        $this->waitFor();
+
         $response = $this->sendMessage('isEditable');
 
         return $this->processBooleanResponse($response);
@@ -87,7 +105,10 @@ public function isEditable(): bool
      */
     public function check(): void
     {
+        $this->waitFor();
+
         $response = $this->sendMessage('check');
+
         $this->processVoidResponse($response);
     }
 
@@ -263,8 +284,13 @@ public function getAttribute(string $name): ?string
      */
     public function waitFor(?array $options = null): void
     {
-        $response = $this->sendMessage('waitForSelector', $options ?? []);
-        $this->processVoidResponse($response);
+        try {
+            $response = $this->sendMessage('waitForSelector', $options ?? []);
+
+            $this->processVoidResponse($response);
+        } catch (TimeoutException) {
+            throw new ExpectationFailedException('Element not found.');
+        }
     }
 
     /**

src/Playwright/Page.php

@@ -53,6 +53,7 @@ public function goto(string $url): self
         }
 
         $response = $this->sendMessage('goto', ['url' => $url, 'waitUntil' => 'load']);
+
         $this->processNavigationResponse($response);
 
         return $this;

tests/Browser/Expectations/ToBeCheckedTest.php

@@ -2,28 +2,8 @@
 
 declare(strict_types=1);
 
-use PHPUnit\Framework\ExpectationFailedException;
-
-it('passes when checkbox is checked', function (): void {
+it('passes if checkbox is checked', function (): void {
     $page = page()->goto('/test/form-inputs');
 
     expect($page->locator('input[name="checked-checkbox"]'))->toBeChecked();
 });
-
-it('fails when checkbox is checked', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="checked-checkbox"]'))->not->toBeChecked();
-})->throws(ExpectationFailedException::class);
-
-it('passes when checkbox is not checked', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="unchecked-checkbox"]'))->not->toBeChecked();
-});
-
-it('fails when checkbox is not checked', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="unchecked-checkbox"]'))->toBeChecked();
-})->throws(ExpectationFailedException::class);

tests/Browser/Expectations/ToBeDisabledTest.php

@@ -2,32 +2,12 @@
 
 declare(strict_types=1);
 
-use PHPUnit\Framework\ExpectationFailedException;
-
 it('passes when input is disabled', function (): void {
     $page = page()->goto('/test/form-inputs');
 
     expect($page->locator('input[name="disabled-input"]'))->toBeDisabled();
 });
 
-it('fails when input is disabled', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="disabled-input"]'))->not->toBeDisabled();
-})->throws(ExpectationFailedException::class);
-
-it('passes when input is not disabled', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="enabled-input"]'))->not->toBeDisabled();
-});
-
-it('fails when input is not disabled', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="enabled-input"]'))->toBeDisabled();
-})->throws(ExpectationFailedException::class);
-
 it('passes when button is disabled', function (): void {
     $page = page()->goto('/test/form-inputs');
 

tests/Browser/Expectations/ToBeEditableTest.php

@@ -2,40 +2,8 @@
 
 declare(strict_types=1);
 
-use PHPUnit\Framework\ExpectationFailedException;
-
 it('passes when input is editable', function (): void {
     $page = page()->goto('/test/form-inputs');
 
     expect($page->locator('input[name="enabled-input"]'))->toBeEditable();
 });
-
-it('fails when input is editable', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="enabled-input"]'))->not->toBeEditable();
-})->throws(ExpectationFailedException::class);
-
-it('passes when input is not editable (readonly)', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="readonly-input"]'))->not->toBeEditable();
-});
-
-it('fails when input is not editable (readonly)', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="readonly-input"]'))->toBeEditable();
-})->throws(ExpectationFailedException::class);
-
-it('passes when input is not editable (disabled)', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="disabled-input"]'))->not->toBeEditable();
-});
-
-it('fails when input is not editable (disabled)', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="disabled-input"]'))->toBeEditable();
-})->throws(ExpectationFailedException::class);

tests/Browser/Expectations/ToBeEmptyTest.php

@@ -2,28 +2,8 @@
 
 declare(strict_types=1);
 
-use PHPUnit\Framework\ExpectationFailedException;
-
 it('passes when element is empty', function (): void {
     $page = page()->goto('/test/form-inputs');
 
     expect($page->locator('#empty-element'))->toBeEmpty();
 });
-
-it('fails when element is not empty', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('label[for="email"]'))->toBeEmpty();
-})->throws(ExpectationFailedException::class);
-
-it('passes when element is not empty and we expect it not to be', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('label[for="email"]'))->not->toBeEmpty();
-});
-
-it('fails when element is empty but we expect it not to be', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('#empty-element'))->not->toBeEmpty();
-})->throws(ExpectationFailedException::class);

tests/Browser/Expectations/ToBeEnabledTest.php

@@ -2,40 +2,14 @@
 
 declare(strict_types=1);
 
-use PHPUnit\Framework\ExpectationFailedException;
-
 it('passes when input is enabled', function (): void {
     $page = page()->goto('/test/form-inputs');
 
     expect($page->locator('input[name="enabled-input"]'))->toBeEnabled();
 });
 
-it('fails when input is enabled', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="enabled-input"]'))->not->toBeEnabled();
-})->throws(ExpectationFailedException::class);
-
-it('passes when input is not enabled', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="disabled-input"]'))->not->toBeEnabled();
-});
-
-it('fails when input is not enabled', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="disabled-input"]'))->toBeEnabled();
-})->throws(ExpectationFailedException::class);
-
 it('passes when button is enabled', function (): void {
     $page = page()->goto('/test/form-inputs');
 
     expect($page->locator('button[name="enabled-button"]'))->toBeEnabled();
 });
-
-it('passes when button is not enabled', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('button[name="disabled-button"]'))->not->toBeEnabled();
-});

tests/Browser/Expectations/ToBeHiddenTest.php

@@ -2,28 +2,8 @@
 
 declare(strict_types=1);
 
-use PHPUnit\Framework\ExpectationFailedException;
-
 it('passes when element is hidden', function (): void {
     $page = page()->goto('/test/form-inputs');
 
     expect($page->locator('input[name="hidden"]'))->toBeHidden();
 });
-
-it('fails when element is hidden', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="hidden"]'))->not->toBeHidden();
-})->throws(ExpectationFailedException::class);
-
-it('passes when element is not hidden', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="visible"]'))->not->toBeHidden();
-});
-
-it('fails when element is not hidden', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="visible"]'))->toBeHidden();
-})->throws(ExpectationFailedException::class);

tests/Browser/Expectations/ToBeVisibleTest.php

@@ -2,28 +2,8 @@
 
 declare(strict_types=1);
 
-use PHPUnit\Framework\ExpectationFailedException;
-
 it('passes when element is visible', function (): void {
     $page = page()->goto('/test/form-inputs');
 
     expect($page->locator('input[name="visible"]'))->toBeVisible();
 });
-
-it('fails when element is visible', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="visible"]'))->not->toBeVisible();
-})->throws(ExpectationFailedException::class);
-
-it('passes when element is not visible', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="hidden"]'))->not->toBeVisible();
-});
-
-it('fails when element is not visible', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="hidden"]'))->toBeVisible();
-})->throws(ExpectationFailedException::class);

tests/Browser/Expectations/ToHaveClassTest.php

@@ -2,28 +2,8 @@
 
 declare(strict_types=1);
 
-use PHPUnit\Framework\ExpectationFailedException;
-
 it('passes when element has the expected class', function (): void {
     $page = page()->goto('/test/form-inputs');
 
     expect($page->locator('input[name="default-checkbox"]'))->toHaveClass('check-class');
 });
-
-it('fails when element does not have the expected class', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="default-checkbox"]'))->toHaveClass('some-other-class');
-})->throws(ExpectationFailedException::class);
-
-it('passes when element does not have the class and we expect it not to', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="default-checkbox"]'))->not->toHaveClass('some-other-class');
-});
-
-it('fails when element has the class but we expect it not to', function (): void {
-    $page = page()->goto('/test/form-inputs');
-
-    expect($page->locator('input[name="default-checkbox"]'))->not->toHaveClass('check-class');
-})->throws(ExpectationFailedException::class);