refactor(create-pull-request): extract methods to adhere to SRP and enhance maintainability#3773
Closed
neilime wants to merge 1 commit intopeter-evans:mainfrom
neilime:refactor/create-pull-request
Closed
refactor(create-pull-request): extract methods to adhere to SRP and enhance maintainability#3773neilime wants to merge 1 commit intopeter-evans:mainfrom neilime:refactor/create-pull-request
neilime wants to merge 1 commit intopeter-evans:mainfrom
neilime:refactor/create-pull-request
Conversation
Author
|
@peter-evans do you need anything to help review /merging this PR? Do not hesitate to let me know. |
…nhance maintainability Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
Owner
|
Hi @neilime I really appreciate the effort to contribute, thank you. However, I don't feel this is necessary at the moment. Perhaps it could do with a refactor, but since I have to maintain this code I would rather do it myself so I know what I've done. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request to propose some refactoring on main method "create-pull-request", in order to make it more readable and I hope maintainable.
There is no behavior change
Mostly, split in smaller dedicated methods and improving some typing