Python3 support (work in progress).#10
Python3 support (work in progress).#10skakri wants to merge 2 commits intopetercollingridge:masterfrom
Conversation
Adjusted code to conform to pep8 standard. Removed trailing whitespace.
|
Hi, Peter. This pull request is work in progress to keep you up to date with the changes I've implemented/intending to implement. I've stumbled upon your project and wanted to use it in my application, which uses Python3 (my scope is – upload SVG, clean it up, remove styles and style it via external, generated CSS). This is a stub to add Python 3 support. I intend to use six compatibility layer, to keep Python 2 support. I've also renamed internal/external functions, to use underscored naming. If you think that this change could break users' code, we could add camelCased function aliases with deprecation messages. I'd like to also rename module name (file cleanSVG.py) to clean_svg if you don't mind. Also I wish to implement two extra (optional) named parameters to I need this to be implemented "as soon as possible"™, so I'm going to make a sub-branch from this one and rebase later, if that's okay. I'm open to comments and suggestions. |
|
I just checked, actually these changes work with Python 2 just fine (tests would be great though, as I've tested with only a couple of SVGs). |
Python 3 support.