fix: add pagination, error handling, and modernize runtime#3
Open
peterkrauz wants to merge 1 commit into
Open
Conversation
The action silently returned incomplete results on PRs with >30 comments because the GitHub API was never paginated. HTTP errors were also swallowed, producing opaque crashes instead of actionable messages. - Paginate GitHub API responses (up to 1000 comments) - Raise on non-200 HTTP status with context - Use exit codes instead of stdout sentinel for success/failure - Upgrade Python 3.7 (EOL) to 3.13 and requests to 2.32.3 - Remove unused apt packages (curl, jq) from Docker image - Fix publish workflow trigger and pin third-party action to SHA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Link: rel="next"headers, fetching up to 1,000 comments (10 pages × 100). Previously only the first 30 were fetched, causing false negatives on active PRs.requests2.27.1 → 2.32.3, removed unusedcurl/jqfrom the Docker image.Other improvements
"0"stdout sentinelset -euo pipefailin entrypointlogging,dumps)@v0, removed unnecessarycontainer:line, mentions paginationTest plan
RuntimeErrorinstead of a crash