Skip to content

Commit 207702c

Browse files
committed
Build/Test Tools: Change how BASE_TAG version is downlaoded.
Recent attempts to change the `BASE_TAG` version in the Performance Testing workflows in [60324] and [62402] have failed due to memory exhaustion errors when trying to download the version using WP-CLI in the local Docker environment. While the. performance tests are run within the Docker environment, there’s no hard requirement for the `wp core download` command to happen through the `wordpressdevelop/cli` conatiner. This adjusts the workflow to perform the failing WP-CLI call within the GitHub Action runner and outside of Docker to avoid the memory exhaustion issue. Props westonruter, swissspidy. Fixes #65289. git-svn-id: https://develop.svn.wordpress.org/trunk@62406 602fd350-edb4-49c9-b593-d223f7449a82
1 parent f4d2f29 commit 207702c

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

.github/workflows/reusable-performance-test-v2.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ jobs:
7878
# - Configure environment variables.
7979
# - Checkout repository.
8080
# - Set up Node.js.
81+
# - Set up PHP.
8182
# - Log debug information.
8283
# - Install npm dependencies.
8384
# - Install Playwright browsers.
@@ -127,6 +128,14 @@ jobs:
127128
node-version-file: '.nvmrc'
128129
cache: npm
129130

131+
- name: Set up PHP
132+
if: ${{ inputs.subject == 'base' }}
133+
uses: shivammathur/setup-php@7c071dfe9dc99bdf297fa79cb49ea005b9fcadbc # 2.37.1
134+
with:
135+
php-version: ${{ inputs.php-version }}
136+
tools: wp-cli
137+
coverage: none
138+
130139
- name: Log debug information
131140
run: |
132141
npm --version
@@ -183,7 +192,7 @@ jobs:
183192
if: ${{ inputs.subject == 'base' }}
184193
run: |
185194
VERSION="${BASE_TAG%.0}"
186-
npm run env:cli -- core download --version="$VERSION" --force --path="/var/www/${LOCAL_DIR}"
195+
wp core download --version="$VERSION" --force --path="${LOCAL_DIR}"
187196
188197
- name: Install object cache drop-in
189198
if: ${{ inputs.memcached }}

0 commit comments

Comments
 (0)