Build/Test Tools: Improve the constants defined for PHPStan.

Many constants were defined as empty strings, including ones that never hold an empty value in a real install. Realistic values are provided for those, matching what wp-settings.php and default-constants.php would produce, so that functions building on them can be given narrower types without the placeholder itself violating them. Constants core itself defines as empty, such as WP_DEVELOPMENT_MODE and COOKIE_DOMAIN, are left as they were.

Developed as subset of WordPress#11851.

See #64898.


git-svn-id: https://develop.svn.wordpress.org/trunk@62965 602fd350-edb4-49c9-b593-d223f7449a82

Author: westonruter

tests/phpstan/bootstrap.php

@@ -7,7 +7,14 @@
  * Loaded as a `bootstrapFile` by PHPStan; see `base.neon`.
  */
 
-// wp_initial_constants()
+/*
+ * A fixed, fictional path rather than the real checkout location. PHPStan resolves
+ * no files through this constant, and deriving it from __DIR__ embeds the developer's
+ * own path in error messages, making output differ between machines.
+ */
+define( 'ABSPATH', '/var/www/html/' );
+
+/** @see wp_initial_constants() */
 define( 'KB_IN_BYTES', 1024 );
 define( 'MB_IN_BYTES', 1024 * KB_IN_BYTES );
 define( 'GB_IN_BYTES', 1024 * MB_IN_BYTES );
@@ -16,9 +23,10 @@
 define( 'EB_IN_BYTES', 1024 * PB_IN_BYTES );
 define( 'ZB_IN_BYTES', 1024 * EB_IN_BYTES );
 define( 'YB_IN_BYTES', 1024 * ZB_IN_BYTES );
-define( 'WP_START_TIMESTAMP', microtime( true ) );
-define( 'WP_MEMORY_LIMIT', '' );
-define( 'WP_MAX_MEMORY_LIMIT', '' );
+define( 'WP_START_TIMESTAMP', 1700000000.0 ); // Fixed rather than microtime( true ), whose value would differ on every run.
+define( 'WP_MEMORY_LIMIT', '40M' );
+define( 'WP_MAX_MEMORY_LIMIT', '256M' );
+define( 'WP_CONTENT_DIR', ABSPATH . 'wp-content' );
 define( 'WP_DEVELOPMENT_MODE', '' );
 define( 'WP_DEBUG', false );
 define( 'WP_DEBUG_DISPLAY', false );
@@ -35,25 +43,25 @@
 define( 'MONTH_IN_SECONDS', 30 * DAY_IN_SECONDS );
 define( 'YEAR_IN_SECONDS', 365 * DAY_IN_SECONDS );
 
-// wp_set_lang_dir()
-define( 'WP_LANG_DIR', '' );
+/** @see wp_set_lang_dir() */
+define( 'WP_LANG_DIR', WP_CONTENT_DIR . '/languages' );
 
 // wp_plugin_directory_constants()
-define( 'WP_CONTENT_URL', '' );
-define( 'WP_PLUGIN_DIR', '' );
-define( 'WP_PLUGIN_URL', '' );
-define( 'PLUGINDIR', '' );
-define( 'WPMU_PLUGIN_DIR', '' );
-define( 'WPMU_PLUGIN_URL', '' );
-define( 'MUPLUGINDIR', '' );
+define( 'WP_CONTENT_URL', 'https://example.com/wp-content' );
+define( 'WP_PLUGIN_DIR', WP_CONTENT_DIR . '/plugins' );
+define( 'WP_PLUGIN_URL', WP_CONTENT_URL . '/plugins' );
+define( 'PLUGINDIR', 'wp-content/plugins' );
+define( 'WPMU_PLUGIN_DIR', WP_CONTENT_DIR . '/mu-plugins' );
+define( 'WPMU_PLUGIN_URL', WP_CONTENT_URL . '/mu-plugins' );
+define( 'MUPLUGINDIR', 'wp-content/mu-plugins' );
 
-// ms_cookie_constants()
+/** @see ms_cookie_constants() */
 define( 'COOKIEPATH', '' );
 define( 'SITECOOKIEPATH', '' );
 define( 'ADMIN_COOKIE_PATH', '' );
 define( 'COOKIE_DOMAIN', '' );
 
-// wp_cookie_constants()
+/** @see wp_cookie_constants() */
 define( 'COOKIEHASH', '' );
 define( 'USER_COOKIE', '' );
 define( 'PASS_COOKIE', '' );
@@ -64,34 +72,34 @@
 define( 'PLUGINS_COOKIE_PATH', '' );
 define( 'RECOVERY_MODE_COOKIE', '' );
 
-// wp_ssl_constants()
+/** @see wp_ssl_constants() */
 define( 'FORCE_SSL_LOGIN', false );
 define( 'FORCE_SSL_ADMIN', false );
 
-// wp_functionality_constants()
+/** @see wp_functionality_constants() */
 define( 'AUTOSAVE_INTERVAL', MINUTE_IN_SECONDS );
 define( 'EMPTY_TRASH_DAYS', 1 );
 define( 'WP_POST_REVISIONS', true );
 define( 'WP_CRON_LOCK_TIMEOUT', MINUTE_IN_SECONDS );
 
-// wp_templating_constants()
-define( 'TEMPLATEPATH', '' );
-define( 'STYLESHEETPATH', '' );
-define( 'WP_DEFAULT_THEME', '' );
+/** @see wp_templating_constants() */
+define( 'TEMPLATEPATH', WP_CONTENT_DIR . '/themes/twentytwentyfive' );
+define( 'STYLESHEETPATH', WP_CONTENT_DIR . '/themes/twentytwentyfive' );
+define( 'WP_DEFAULT_THEME', 'twentytwentyfive' );
 
-// ms_file_constants()
+/** @see ms_file_constants() */
 define( 'WPMU_SENDFILE', false );
 define( 'WPMU_ACCEL_REDIRECT', false );
 
-// ms_load_current_site_and_network()
+/** @see ms_load_current_site_and_network() */
 define( 'NOBLOGREDIRECT', '' );
 
-// ms_upload_constants()
-define( 'UPLOADBLOGSDIR', '' );
-define( 'BLOGUPLOADDIR', '' );
+/** @see ms_upload_constants() */
+define( 'UPLOADBLOGSDIR', 'wp-content/blogs.dir' );
+define( 'BLOGUPLOADDIR', WP_CONTENT_DIR . '/blogs.dir/1/files/' );
 
-// Misc constants not part of the default lifecycle.
-define( 'FS_CONNECT_TIMEOUT', 1 );
-define( 'FS_TIMEOUT', 1 );
-define( 'FS_CHMOD_DIR', 1 );
-define( 'FS_CHMOD_FILE', 1 );
+/** @see WP_Filesystem() */
+define( 'FS_CONNECT_TIMEOUT', 30 ); // 30 seconds.
+define( 'FS_TIMEOUT', 30 ); // 30 seconds.
+define( 'FS_CHMOD_DIR', 0755 );
+define( 'FS_CHMOD_FILE', 0644 );