Tests: Use assertTrue()/assertFalse() instead of assertSame() with booleans.

Using the dedicated boolean assertions clarifies intent and produces more descriptive failure messages.

Follow-up to [51453].

Props Soean, mukesh27.
See #64894.

git-svn-id: https://develop.svn.wordpress.org/trunk@62969 602fd350-edb4-49c9-b593-d223f7449a82

Author: SergeyBiryukov

tests/phpunit/tests/blocks/wpBlockType.php

@@ -528,9 +528,9 @@ public function test_variations_callback_are_lazy_loaded() {
 			)
 		);
 
-		$this->assertSame( false, $callback_called, 'The callback should not be called before the variations are accessed.' );
+		$this->assertFalse( $callback_called, 'The callback should not be called before the variations are accessed.' );
 		$block_type->variations; // access the variations.
-		$this->assertSame( true, $callback_called, 'The callback should be called when the variations are accessed.' );
+		$this->assertTrue( $callback_called, 'The callback should be called when the variations are accessed.' );
 	}
 
 	/**
@@ -555,7 +555,7 @@ public function test_variations_precedence_over_callback_post_registration() {
 
 		// If the variations are defined after registration but before first access, the callback should not override it.
 		$this->assertSameSets( $test_variations, $block_type->get_variations(), 'Variations are same as variations set' );
-		$this->assertSame( false, $callback_called, 'The callback was never called.' );
+		$this->assertFalse( $callback_called, 'The callback was never called.' );
 	}
 
 	/**
@@ -617,7 +617,7 @@ public function test_get_block_type_variations_filter_with_variation_callback()
 
 		$obtained_variations = $block_type->variations; // access the variations.
 
-		$this->assertSame( true, $callback_called, 'The callback should be called when the variations are accessed.' );
+		$this->assertTrue( $callback_called, 'The callback should be called when the variations are accessed.' );
 		$this->assertSameSets( $obtained_variations, $expected_variations, 'The variations obtained from the callback should be filtered.' );
 	}
 

tests/phpunit/tests/interactivity-api/wpInteractivityAPI-wp-bind.php

@@ -454,7 +454,7 @@ public function test_wp_bind_handles_nested_bindings() {
 	public function test_wp_bind_handles_true_value() {
 		$html    = '<div data-wp-bind--id="myPlugin::state.trueValue"></div>';
 		list($p) = $this->process_directives( $html );
-		$this->assertSame( true, $p->get_attribute( 'id' ) );
+		$this->assertTrue( $p->get_attribute( 'id' ) );
 	}
 
 	/**
@@ -467,7 +467,7 @@ public function test_wp_bind_handles_true_value() {
 	public function test_wp_bind_ignores_unique_ids() {
 		$html    = '<div data-wp-bind--id="myPlugin::state.trueValue"></div>';
 		list($p) = $this->process_directives( $html );
-		$this->assertSame( true, $p->get_attribute( 'id' ) );
+		$this->assertTrue( $p->get_attribute( 'id' ) );
 
 		$html    = '<div data-wp-bind--id---unique-id="myPlugin::state.trueValue"></div>';
 		list($p) = $this->process_directives( $html );

tests/phpunit/tests/rest-api/rest-post-meta-fields.php

@@ -2348,7 +2348,7 @@ public function test_update_meta_with_unchanged_values_and_custom_authentication
 		$this->assertSame( 200, $response->get_status() );
 
 		$data = $response->get_data();
-		$this->assertSame( false, $data['meta']['authenticated'] );
+		$this->assertFalse( $data['meta']['authenticated'] );
 	}
 
 	/**

tests/phpunit/tests/rest-api/wpRestMenusController.php

@@ -316,7 +316,7 @@ public function test_update_item() {
 		$data = $response->get_data();
 		$this->assertSame( 'New Name', $data['name'] );
 		$this->assertSame( 'New Description', $data['description'] );
-		$this->assertSame( true, $data['auto_add'] );
+		$this->assertTrue( $data['auto_add'] );
 		$this->assertSame( 'new-name', $data['slug'] );
 		$this->assertSame( 'just meta', $data['meta']['test_single_menu'] );
 		$this->assertFalse( isset( $data['meta']['test_cat_meta'] ) );