Skip to content

Commit baab2b8

Browse files
Coding Standards: Remove a one-time $sql variable in Edit Site form.
This allows the `$wpdb::prepare()` call to be picked up correctly by PHPCS. Follow-up to [28712]. Props aristath, poena, afercia, SergeyBiryukov. See #63168. git-svn-id: https://develop.svn.wordpress.org/trunk@60101 602fd350-edb4-49c9-b593-d223f7449a82
1 parent a1b24c9 commit baab2b8

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

src/wp-admin/network/site-settings.php

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,15 +121,16 @@
121121
<table class="form-table" role="presentation">
122122
<?php
123123
$blog_prefix = $wpdb->get_blog_prefix( $id );
124-
$sql = "SELECT * FROM {$blog_prefix}options
125-
WHERE option_name NOT LIKE %s
126-
AND option_name NOT LIKE %s";
127-
$query = $wpdb->prepare(
128-
$sql,
129-
$wpdb->esc_like( '_' ) . '%',
130-
'%' . $wpdb->esc_like( 'user_roles' )
124+
$options = $wpdb->get_results(
125+
$wpdb->prepare(
126+
'SELECT * FROM %i
127+
WHERE option_name NOT LIKE %s
128+
AND option_name NOT LIKE %s',
129+
"{$blog_prefix}options",
130+
$wpdb->esc_like( '_' ) . '%',
131+
'%' . $wpdb->esc_like( 'user_roles' )
132+
)
131133
);
132-
$options = $wpdb->get_results( $query );
133134

134135
foreach ( $options as $option ) {
135136
if ( 'default_role' === $option->option_name ) {

0 commit comments

Comments
 (0)