Fix warning in need_more_shared_native_threads_p

peterzhu2118 · peterzhu2118 · commit 900d43ddf40d · 2026-02-07T20:12:26.000-05:00
thread_pthread.c:573:20: warning: comparison of unsigned expression in `&lt; 0` is always false [-Wtype-limits]
      573 |     return snt_cnt &lt; MINIMUM_SNT || (snt_cnt &lt; schedulable_ractor_cnt &amp;&amp; snt_cnt &lt; vm-&gt;ractor.sched.max_cpu);
          |
diff --git a/thread_pthread.c b/thread_pthread.c
@@ -570,7 +570,11 @@ need_more_shared_native_threads_p(rb_vm_t *vm)
     if (!vm->ractor.main_ractor->threads.sched.enable_mn_threads) {
         schedulable_ractor_cnt--; // do not need snt for main ractor
     }
-    return snt_cnt < MINIMUM_SNT || (snt_cnt < schedulable_ractor_cnt && snt_cnt < vm->ractor.sched.max_cpu);
+    return
+#if MINIMUM_SNT != 0
+        snt_cnt < MINIMUM_SNT ||
+#endif
+            (snt_cnt < schedulable_ractor_cnt && snt_cnt < vm->ractor.sched.max_cpu);
 }
 
 // setup timeslice signals by the timer thread.

Original file line number	Diff line number	Diff line change
`@@ -570,7 +570,11 @@ need_more_shared_native_threads_p(rb_vm_t *vm)`
`570`	`570`	`if (!vm->ractor.main_ractor->threads.sched.enable_mn_threads) {`
`571`	`571`	`schedulable_ractor_cnt--; // do not need snt for main ractor`
`572`	`572`	`}`
`573`		`- return snt_cnt < MINIMUM_SNT \|\| (snt_cnt < schedulable_ractor_cnt && snt_cnt < vm->ractor.sched.max_cpu);`
	`573`	`+ return`
	`574`	`+#if MINIMUM_SNT != 0`
	`575`	`+ snt_cnt < MINIMUM_SNT \|\|`
	`576`	`+#endif`
	`577`	`+ (snt_cnt < schedulable_ractor_cnt && snt_cnt < vm->ractor.sched.max_cpu);`
`574`	`578`	`}`
`575`	`579`
`576`	`580`	`// setup timeslice signals by the timer thread.`