updated logging, tests

Author: petesramek

src/PolylineAlgorithm.Abstraction/AbstractPolylineEncoder.cs

@@ -82,12 +82,12 @@ public TPolyline Encode(IEnumerable<TCoordinate> coordinates) {
                 throw new InternalBufferOverflowException();
             }
 
-            if (!PolylineEncoding.TryWriteValue(variance.Latitude, ref buffer, ref position)
-                || !PolylineEncoding.TryWriteValue(variance.Longitude, ref buffer, ref position)
+            if (PolylineEncoding.TryWriteValue(variance.Latitude, ref buffer, ref position)
+                || PolylineEncoding.TryWriteValue(variance.Longitude, ref buffer, ref position)
             ) {
                 // This shouldn't happen, but if it does, log the error and throw an exception.
                 Options
-                    .UseLoggerFor<AbstractPolylineEncoder<TCoordinate, TPolyline>>().LogCannotWriteValueToBufferError(position);
+                    .UseLoggerFor<AbstractPolylineEncoder<TCoordinate, TPolyline>>().LogCannotWriteValueToBufferError(position, consumed);
                 throw new InvalidOperationException();
             }
 

src/PolylineAlgorithm.Abstraction/Internal/Logging.cs

@@ -12,8 +12,8 @@ internal static partial class Logging {
     [LoggerMessage(3, LogLevel.Error, "Internal buffer has {bufferLength} length. At position {position} is required additional {requiredSpace} length.")]
     internal static partial void LogInternalBufferOverflowError(this ILogger logger, int position, int bufferLength, int requiredSpace);
 
-    [LoggerMessage(4, LogLevel.Error, "Cannot write to internal buffer at position {position}.")]
-    internal static partial void LogCannotWriteValueToBufferError(this ILogger logger, int position);
+    [LoggerMessage(4, LogLevel.Error, "Cannot write to internal buffer at position {position}. Current coordinate index is {coordinateIndex}")]
+    internal static partial void LogCannotWriteValueToBufferError(this ILogger logger, int position, int coordinateIndex);
 
     [LoggerMessage(5, LogLevel.Error, "Argument {argumentName} is too short. Minimal length is {minimumLength}. Actual length is {actualLength}.")]
     internal static partial void LogPolylineCannotBeShorterThanError(this ILogger logger, string argumentName, int actualLength, int minimumLength);

tests/PolylineAlgorithm.Abstraction.Tests/Internal/LoggingTest.cs

@@ -73,16 +73,19 @@ public void ILogger_LogInternalBufferOverflowError_Ok() {
     public void ILogger_LogCannotWriteValueToBufferError_Ok() {
         // Arrange
         int position = 5;
+        int index = 1;
 
         // Act
         _loggerFactory
             .CreateLogger<LoggingTest>()
-            .LogCannotWriteValueToBufferError(position);
+            .LogCannotWriteValueToBufferError(position, index);
 
         // Assert
         Assert.AreEqual(4, _loggerProvider.Collector.LatestRecord.Id);
         Assert.AreEqual(LogLevel.Error, _loggerProvider.Collector.LatestRecord.Level);
-        Assert.AreEqual($"Cannot write to internal buffer at position {position}.", _loggerProvider.Collector.LatestRecord.Message);
+        Assert.AreEqual(
+            $"Cannot write to internal buffer at position {position}. Current coordinate index is {index}.",
+            _loggerProvider.Collector.LatestRecord.Message);
     }
 
     [TestMethod]