clean up, removed CPM, fixed errors, fixed releavant warnings, suppressed irrelevant warnings.

Author: petesramek

.editorconfig

@@ -1,4 +1,4 @@
-# Remove the line below if you want to inherit .editorconfig settings from higher directories
+# Remove the line below if you want to inherit .editorconfig settings from higher directories
 root = true
 
 # All files
@@ -131,7 +131,7 @@ csharp_prefer_simple_using_statement = false
 csharp_prefer_system_threading_lock = true
 csharp_style_namespace_declarations = file_scoped
 csharp_style_prefer_method_group_conversion = false
-csharp_style_prefer_primary_constructors = true
+csharp_style_prefer_primary_constructors = false
 csharp_style_prefer_top_level_statements = false
 
 # Expression-level preferences

Directory.Build.props

@@ -16,10 +16,10 @@
 	</PropertyGroup>
 
 	<ItemGroup>
-		<PackageReference Include="Roslynator.Analyzers" PrivateAssets="all" />
-		<PackageReference Include="Meziantou.Analyzer" PrivateAssets="all" />
-		<PackageReference Include="SonarAnalyzer.CSharp" PrivateAssets="all" />
-		<PackageReference Include="SmartAnalyzers.ExceptionAnalyzer" PrivateAssets="all" />
+		<PackageReference Include="Roslynator.Analyzers" Version="4.*" PrivateAssets="all" />
+		<PackageReference Include="Meziantou.Analyzer" Version="3.*" PrivateAssets="all" />
+		<PackageReference Include="SonarAnalyzer.CSharp" Version="10.*" PrivateAssets="all" />
+		<PackageReference Include="SmartAnalyzers.ExceptionAnalyzer" Version="1.*" PrivateAssets="all" />
 	</ItemGroup>
 
 </Project>

Directory.Packages.props

@@ -1,7 +1,6 @@
 <Solution>
   <Folder Name="/.build/">
     <File Path="Directory.Build.props" />
-    <File Path="Directory.Packages.props" />
   </Folder>
   <Folder Name="/benchmarks/">
     <Project Path="benchmarks/PolylineAlgorithm.Benchmarks/PolylineAlgorithm.Benchmarks.csproj" />

PolylineAlgorithm.slnx

@@ -19,9 +19,9 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="BenchmarkDotNet" />
-		<PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" />
-		<PackageReference Include="Microsoft.VisualStudio.DiagnosticsHub.BenchmarkDotNetDiagnosers" />
+		<PackageReference Include="BenchmarkDotNet" Version="0.15.8" />
+		<PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.15.8" />
+		<PackageReference Include="Microsoft.VisualStudio.DiagnosticsHub.BenchmarkDotNetDiagnosers" Version="18.6.37110.2" />
 	</ItemGroup>
 
 	<ItemGroup>

benchmarks/PolylineAlgorithm.Benchmarks/PolylineAlgorithm.Benchmarks.csproj

@@ -20,7 +20,7 @@ public class PolylineBenchmark {
     /// Number of coordinates for benchmarks. Set by BenchmarkDotNet.
     /// </summary>
     [Params(1, 100, 1_000)]
-    public int CoordinatesCount;
+    public int CoordinatesCount { get; set; }
 
 #pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring as nullable.
     /// <summary>
@@ -54,7 +54,6 @@ public class PolylineBenchmark {
     /// and is used as the target buffer for copying polyline data during benchmark runs.
     /// </summary>
     public char[] CopyToDestination { get; private set; }
-
 #pragma warning restore CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring as nullable.
 
 

benchmarks/PolylineAlgorithm.Benchmarks/PolylineBenchmark.cs

@@ -18,7 +18,7 @@ public class PolylineDecoderBenchmark {
     private readonly Consumer _consumer = new();
 
     [Params(1, 100, 1_000)]
-    public int CoordinatesCount;
+    public int CoordinatesCount { get; set; }
 
 #pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring as nullable.
     /// <summary>
@@ -46,7 +46,7 @@ public class PolylineDecoderBenchmark {
     /// <summary>
     /// Polyline decoder instance.
     /// </summary>
-    public readonly PolylineDecoder Decoder = new();
+    private readonly PolylineDecoder _decoder = new();
 
     /// <summary>
     /// Sets up benchmark data.
@@ -64,7 +64,7 @@ public void SetupData() {
     /// </summary>
     [Benchmark]
     public void PolylineDecoder_Decode_Polyline() {
-        Decoder
+        _decoder
             .Decode(Polyline)
             .Consume(_consumer);
     }
@@ -74,7 +74,7 @@ public void PolylineDecoder_Decode_Polyline() {
     /// </summary>
     [Benchmark]
     public void PolylineDecoder_Decode_String() {
-        Decoder
+        _decoder
             .Decode(String)
             .Consume(_consumer);
     }
@@ -84,7 +84,7 @@ public void PolylineDecoder_Decode_String() {
     /// </summary>
     [Benchmark]
     public void PolylineDecoder_Decode_CharArray() {
-        Decoder
+        _decoder
             .Decode(CharArray)
             .Consume(_consumer);
     }
@@ -94,7 +94,7 @@ public void PolylineDecoder_Decode_CharArray() {
     /// </summary>
     [Benchmark]
     public void PolylineDecoder_Decode_Memory() {
-        Decoder
+        _decoder
             .Decode(Memory)
             .Consume(_consumer);
     }

benchmarks/PolylineAlgorithm.Benchmarks/PolylineDecoderBenchmark.cs

@@ -22,7 +22,7 @@ public class PolylineEncoderBenchmark {
     /// Number of coordinates for benchmarks.
     /// </summary>
     [Params(1, 100, 1_000)]
-    public int CoordinatesCount;
+    public int CoordinatesCount { get; set; }
 
 #pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring as nullable.
     /// <summary>
@@ -45,14 +45,14 @@ public class PolylineEncoderBenchmark {
     /// <summary>
     /// Polyline encoder instance.
     /// </summary>
-    public readonly PolylineEncoder Encoder = new();
+    private readonly PolylineEncoder _encoder = new();
 
     /// <summary>
     /// Sets up benchmark data.
     /// </summary>
     [GlobalSetup]
     public void SetupData() {
-        List = RandomValueProvider.GetCoordinates(CoordinatesCount).Select(c => new Coordinate(c.Latitude, c.Longitude)).ToList();
+        List = [.. RandomValueProvider.GetCoordinates(CoordinatesCount).Select(c => new Coordinate(c.Latitude, c.Longitude))];
         Array = [.. List];
         Memory = Array.AsMemory();
     }
@@ -63,7 +63,7 @@ public void SetupData() {
     /// <returns>Encoded polyline.</returns>
     [Benchmark]
     public void PolylineEncoder_Encode_Span() {
-        var polyline = Encoder
+        var polyline = _encoder
             .Encode(Memory.Span!);
 
         _consumer.Consume(polyline);
@@ -75,7 +75,7 @@ public void PolylineEncoder_Encode_Span() {
     /// <returns>Encoded polyline.</returns>
     [Benchmark]
     public void PolylineEncoder_Encode_Array() {
-        var polyline = Encoder
+        var polyline = _encoder
             .Encode(Array!);
 
         _consumer.Consume(polyline);
@@ -87,7 +87,7 @@ public void PolylineEncoder_Encode_Array() {
     /// <returns>Encoded polyline.</returns>
     [Benchmark]
     public void PolylineEncoder_Encode_List() {
-        var polyline = Encoder
+        var polyline = _encoder
             .Encode(List!);
 
         _consumer.Consume(polyline);

benchmarks/PolylineAlgorithm.Benchmarks/PolylineEncoderBenchmark.cs

@@ -10,7 +10,7 @@ namespace PolylineAlgorithm.Benchmarks;
 /// <summary>
 /// Main entry point for benchmarks.
 /// </summary>
-internal class Program {
+internal static class Program {
     /// <summary>
     /// Runs the benchmarks.
     /// </summary>

benchmarks/PolylineAlgorithm.Benchmarks/Program.cs

@@ -0,0 +1,8 @@
+//
+// Copyright © Pete Sramek. All rights reserved.
+// Licensed under the MIT License. See LICENSE file in the project root for full license information.
+//
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: ExcludeFromCodeCoverage]