updated tests

Author: petesramek

tests/PolylineAlgorithm.Tests/PolylineTest.cs

@@ -40,40 +40,6 @@ public void Constructor_Parameterless_Ok() {
         Assert.IsTrue(polyline.Value.IsEmpty);
     }
 
-    /// <summary>
-    /// Tests the <see cref="Polyline"/> constructor with a null string, expecting an <see cref="ArgumentNullException"/>.
-    /// </summary>
-    [TestMethod]
-    public void Constructor_Null_String_ArgumentNullException() {
-        // Arrange
-        string value = null!;
-
-        // Act
-        static Polyline New(string value) => Polyline.FromString(value);
-
-        // Assert
-        Assert.ThrowsExactly<ArgumentNullException>(() => New(value));
-    }
-
-    /// <summary>
-    /// Tests the <see cref="Polyline"/> constructor with a string parameter.
-    /// </summary>
-    /// <param name="value">The string value.</param>
-    [TestMethod]
-    [DynamicData(nameof(LengthParameters))]
-    public void Constructor_String_Parameter_Ok(int length) {
-        // Arrange
-        var value = RandomValueProvider.GetPolyline(length);
-
-        // Act
-        Polyline result = Polyline.FromString(value);
-
-        // Assert
-        Assert.AreEqual(value.Length, result.Length);
-        Assert.AreEqual(value.Length == 0, result.IsEmpty);
-        Assert.AreEqual(value, result.ToString());
-    }
-
     /// <summary>
     /// Tests the <see cref="Polyline"/> constructor with a null character array, expecting an <see cref="ArgumentNullException"/>.
     /// </summary>
@@ -132,68 +98,13 @@ public void FromMemory_Memory_Parameter_Ok(int size) {
         Assert.AreEqual(polyline.ToString(), result.ToString());
     }
 
-    /// <summary>
-    /// Tests the <see cref="Polyline.FromString(string)"/> method.
-    /// </summary>
-    /// <param name="value">The string value.</param>
-    [TestMethod]
-    [DynamicData(nameof(LengthParameters))]
-    public void FromString_Equals_New(int size) {
-        // Arrange
-        var polyline = RandomValueProvider.GetPolyline(size);
-        bool isEmpty = polyline.Length == 0;
-        long length = polyline.Length;
-
-        // Act
-        Polyline result = Polyline.FromString(polyline);
-
-        // Assert
-        Assert.AreEqual(polyline, result.ToString());
-    }
-
-    /// <summary>
-    /// Tests the <see cref="Polyline.FromCharArray(char[])"/> method.
-    /// </summary>
-    /// <param name="value">The string value.</param>
-    [TestMethod]
-    [DynamicData(nameof(LengthParameters))]
-    public void FromCharArray_Equals_New(int size) {
-        // Arrange
-        char[] array = RandomValueProvider.GetPolyline(size).ToCharArray();
-        Polyline polyline = Polyline.FromCharArray(array);
-
-        // Act
-        Polyline result = Polyline.FromCharArray(array);
-
-        // Assert
-        Assert.IsTrue(polyline.Equals(result));
-    }
-
-    /// <summary>
-    /// Tests the <see cref="Polyline.FromMemory(ReadOnlyMemory{char})"/> method.
-    /// </summary>
-    /// <param name="value">The string value.</param>
-    [TestMethod]
-    [DynamicData(nameof(LengthParameters))]
-    public void FromMemory_Equals_New(int size) {
-        // Arrange
-        ReadOnlyMemory<char> memory = RandomValueProvider.GetPolyline(size).AsMemory();
-        Polyline polyline = Polyline.FromMemory(memory);
-
-        // Act
-        Polyline result = Polyline.FromMemory(memory);
-
-        // Assert
-        Assert.IsTrue(polyline.Equals(result));
-    }
-
     /// <summary>
     /// Tests the <see cref="Polyline.ToString"/> method.
     /// </summary>
     /// <param name="value">The string value.</param>
     [TestMethod]
     [DynamicData(nameof(LengthParameters))]
-    public void ToString_Equals_Constructor_Parameter(int size) {
+    public void ToString_Returns_Correct_String(int size) {
         // Arrange
         Polyline polyline = Polyline.FromString(RandomValueProvider.GetPolyline(size));
         string expected = RandomValueProvider.GetPolyline(size);
@@ -211,7 +122,7 @@ public void ToString_Equals_Constructor_Parameter(int size) {
     /// <param name="value">The string value.</param>
     [TestMethod]
     [DynamicData(nameof(LengthParameters))]
-    public void CopyTo_Equals_Expected_Value(int size) {
+    public void CopyTo_Equals_Correct_CharArray(int size) {
         // Arrange
         Polyline polyline = Polyline.FromString(RandomValueProvider.GetPolyline(size));
         char[] expected = RandomValueProvider.GetPolyline(size).ToCharArray();
@@ -263,19 +174,24 @@ public void CopyTo_Null_Destination_Parameter_Throws_ArgumentNullException(int s
     }
 
     [TestMethod]
-    public void Equality_Operators_OK() {
+    public void Equality_Operators_Correct_Results() {
         // Arrange
-        Polyline first = Polyline.FromString(nameof(first));
-        Polyline equal = Polyline.FromString(nameof(first));
+        Polyline polyline = Polyline.FromString(nameof(polyline));
+        Polyline equal = Polyline.FromString(nameof(polyline));
         Polyline notEqual = Polyline.FromString(nameof(notEqual));
+        string typeNotEqual = "not a polyline";
 
         // Act && Assert
-        Assert.IsTrue(first == equal);
-        Assert.IsTrue(first != notEqual);
-        Assert.IsTrue(first.Equals(equal));
+        Assert.IsTrue(polyline == equal);
+        Assert.IsTrue(polyline != notEqual);
+
+        Assert.IsFalse(polyline != equal);
+        Assert.IsFalse(polyline == notEqual);
+
+        Assert.IsTrue(polyline.Equals(equal));
+        Assert.IsTrue(polyline.Equals((object)equal));
 
-        Assert.IsFalse(first != equal);
-        Assert.IsFalse(first == notEqual);
-        Assert.IsFalse(first.Equals(notEqual));
+        Assert.IsFalse(polyline.Equals((object)notEqual));
+        Assert.IsFalse(polyline.Equals(typeNotEqual));
     }
 }