refactored static value provider

Author: petesramek

tests/PolylineAlgorithm.Tests/PolylineDecoderTest.cs

@@ -71,8 +71,8 @@ public void Random_Value_Decode_Valid_Input_Ok(int count) {
     [TestMethod]
     public void Static_Value_Decode_Valid_Input_Ok() {
         // Arrange
-        IEnumerable<Coordinate> expected = StaticValueProvider.GetCoordinates().Select(c => new Coordinate(c.Latitude, c.Longitude));
-        string value = StaticValueProvider.GetPolyline();
+        IEnumerable<Coordinate> expected = StaticValueProvider.Valid.GetCoordinates().Select(c => new Coordinate(c.Latitude, c.Longitude));
+        string value = StaticValueProvider.Valid.GetPolyline();
 
         // Act
         var result = Decoder.Decode(Polyline.FromString(value));

tests/PolylineAlgorithm.Tests/PolylineEncoderTest.cs

@@ -78,8 +78,8 @@ public void Encode_RandomValue_ValidInput_Ok(int count) {
     [TestMethod]
     public void Encode_StaticValue_ValidInput_Ok() {
         // Arrange
-        IEnumerable<Coordinate> valid = StaticValueProvider.GetCoordinates().Select(c => new Coordinate(c.Latitude, c.Longitude));
-        Polyline expected = Polyline.FromString(StaticValueProvider.GetPolyline());
+        IEnumerable<Coordinate> valid = StaticValueProvider.Valid.GetCoordinates().Select(c => new Coordinate(c.Latitude, c.Longitude));
+        Polyline expected = Polyline.FromString(StaticValueProvider.Valid.GetPolyline());
 
         // Act
         var result = Encoder.Encode(valid);

utilities/PolylineAlgorithm.Utility/StaticValueProvider.cs

@@ -11,38 +11,46 @@ namespace PolylineAlgorithm.Utility;
 /// Provides static, predefined coordinate and polyline values for use in tests and benchmarks.
 /// </summary>
 internal static class StaticValueProvider {
-    /// <summary>
-    /// A predefined polyline instance representing a fixed encoded polyline string.
-    /// </summary>
-    private static readonly string _polyline = "???_gsia@_cidP??~fsia@?~fsia@~bidP?~bidP??_gsia@";
+    internal static class Valid {
+        /// <summary>
+        /// A predefined polyline instance representing a fixed encoded polyline string.
+        /// </summary>
+        private static readonly string _polyline = "???_gsia@_cidP??~fsia@?~fsia@~bidP?~bidP??_gsia@";
 
-    /// <summary>
-    /// A predefined collection of <see cref="Coordinate"/> instances representing a closed path around the globe.
-    /// </summary>
-    private static readonly IEnumerable<(double Latitude, double Longitude)> _coordinates = [
-        new (0, 0),
+        /// <summary>
+        /// A predefined collection of <see cref="Coordinate"/> instances representing a closed path around the globe.
+        /// </summary>
+        private static readonly IEnumerable<(double Latitude, double Longitude)> _coordinates = [
+            new (0, 0),
         new (0, 180),
         new (90, 180),
         new (90, 0),
         new (90, -180),
         new (0, -180),
         new (-90, -180),
         new (-90, 0)
-    ];
+        ];
 
-    /// <summary>
-    /// Gets the predefined collection of <see cref="Coordinate"/> instances.
-    /// </summary>
-    /// <returns>An <see cref="IEnumerable{Coordinate}"/> containing the static coordinates.</returns>
-    public static IEnumerable<(double Latitude, double Longitude)> GetCoordinates() {
-        return _coordinates;
+        /// <summary>
+        /// Gets the predefined collection of <see cref="Coordinate"/> instances.
+        /// </summary>
+        /// <returns>An <see cref="IEnumerable{Coordinate}"/> containing the static coordinates.</returns>
+        public static IEnumerable<(double Latitude, double Longitude)> GetCoordinates() {
+            return _coordinates;
+        }
+
+        /// <summary>
+        /// Gets the predefined <see cref="Polyline"/> instance.
+        /// </summary>
+        /// <returns>The static <see cref="Polyline"/> value.</returns>
+        public static string GetPolyline() {
+            return _polyline;
+        }
     }
 
-    /// <summary>
-    /// Gets the predefined <see cref="Polyline"/> instance.
-    /// </summary>
-    /// <returns>The static <see cref="Polyline"/> value.</returns>
-    public static string GetPolyline() {
-        return _polyline;
+    internal static class Invalid {
+        //public static string GetMalformedPolyline() {
+        //    return ((char)(127)).ToString();
+        //}
     }
 }