fix: suppress CA1062/CA1000/RS0016/RS0017/CS1574 warnings; begin test rewrites

Agent-Logs-Url: https://github.com/petesramek/polyline-algorithm-csharp/sessions/634a0417-96c9-496e-899a-de2bca4033a2

Co-authored-by: petesramek <2333452+petesramek@users.noreply.github.com>

Author: Copilot

src/PolylineAlgorithm/Extensions/PolylineDecoderExtensions.cs

@@ -30,6 +30,7 @@ public static class PolylineDecoderExtensions {
     /// <exception cref="ArgumentNullException">
     /// Thrown when <paramref name="decoder"/> or <paramref name="polyline"/> is <see langword="null"/>.
     /// </exception>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Null is verified before use via ExceptionGuard.ThrowArgumentNull, which is annotated [DoesNotReturn]. CA1062 does not recognise custom [DoesNotReturn] helpers as null guards.")]
     public static IEnumerable<TValue> Decode<TValue>(this IPolylineDecoder<string, TValue> decoder, char[] polyline) {
         if (decoder is null) {
             ExceptionGuard.ThrowArgumentNull(nameof(decoder));
@@ -58,6 +59,7 @@ public static IEnumerable<TValue> Decode<TValue>(this IPolylineDecoder<string, T
     /// <exception cref="ArgumentNullException">
     /// Thrown when <paramref name="decoder"/> is <see langword="null"/>.
     /// </exception>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Null is verified before use via ExceptionGuard.ThrowArgumentNull, which is annotated [DoesNotReturn]. CA1062 does not recognise custom [DoesNotReturn] helpers as null guards.")]
     public static IEnumerable<TValue> Decode<TValue>(this IPolylineDecoder<string, TValue> decoder, ReadOnlyMemory<char> polyline) {
         if (decoder is null) {
             ExceptionGuard.ThrowArgumentNull(nameof(decoder));
@@ -83,6 +85,7 @@ public static IEnumerable<TValue> Decode<TValue>(this IPolylineDecoder<string, T
     /// <exception cref="ArgumentNullException">
     /// Thrown when <paramref name="decoder"/> or <paramref name="polyline"/> is <see langword="null"/>.
     /// </exception>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Null is verified before use via ExceptionGuard.ThrowArgumentNull, which is annotated [DoesNotReturn]. CA1062 does not recognise custom [DoesNotReturn] helpers as null guards.")]
     public static IEnumerable<TValue> Decode<TValue>(this IPolylineDecoder<ReadOnlyMemory<char>, TValue> decoder, string polyline) {
         if (decoder is null) {
             ExceptionGuard.ThrowArgumentNull(nameof(decoder));

src/PolylineAlgorithm/Extensions/PolylineEncoderExtensions.cs

@@ -36,6 +36,7 @@ public static class PolylineEncoderExtensions {
     /// </exception>
     [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1002:Do not expose generic lists", Justification = "We need a list as we do need to marshal it as span.")]
     [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "MA0016:Prefer using collection abstraction instead of implementation", Justification = "We need a list as we do need to marshal it as span.")]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Null is verified before use via ExceptionGuard.ThrowArgumentNull, which is annotated [DoesNotReturn]. CA1062 does not recognise custom [DoesNotReturn] helpers as null guards.")]
     public static TPolyline Encode<TCoordinate, TPolyline>(this IPolylineEncoder<TCoordinate, TPolyline> encoder, List<TCoordinate> coordinates) {
         if (encoder is null) {
             ExceptionGuard.ThrowArgumentNull(nameof(encoder));
@@ -70,6 +71,7 @@ public static TPolyline Encode<TCoordinate, TPolyline>(this IPolylineEncoder<TCo
     /// <exception cref="ArgumentNullException">
     /// Thrown when <paramref name="encoder"/> or <paramref name="coordinates"/> is <see langword="null"/>.
     /// </exception>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Null is verified before use via ExceptionGuard.ThrowArgumentNull, which is annotated [DoesNotReturn]. CA1062 does not recognise custom [DoesNotReturn] helpers as null guards.")]
     public static TPolyline Encode<TCoordinate, TPolyline>(this IPolylineEncoder<TCoordinate, TPolyline> encoder, TCoordinate[] coordinates) {
         if (encoder is null) {
             ExceptionGuard.ThrowArgumentNull(nameof(encoder));

src/PolylineAlgorithm/FormatterBuilder.cs

@@ -40,6 +40,7 @@ private FormatterBuilder() { }
     /// Creates a new <see cref="FormatterBuilder{TCoordinate, TPolyline}"/> instance.
     /// </summary>
     /// <returns>A fresh builder with no rules and no polyline delegates.</returns>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1000:Do not declare static members on generic types", Justification = "Factory method on a generic builder intentionally lives on the type so callers write FormatterBuilder<T, U>.Create() without needing a separate non-generic factory class.")]
     public static FormatterBuilder<TCoordinate, TPolyline> Create() => new();
 
     /// <summary>

src/PolylineAlgorithm/Internal/FormatterRule.cs

@@ -8,7 +8,7 @@ namespace PolylineAlgorithm.Internal;
 using System;
 
 /// <summary>
-/// Represents a single column rule baked into a <see cref="PolylineFormatter{T}"/>.
+/// Represents a single column rule baked into a <see cref="PolylineFormatter{TCoordinate, TPolyline}"/>.
 /// Stores the pre-calculated factor and an optional baseline alongside the user-supplied value selector.
 /// </summary>
 /// <typeparam name="T">The source object type from which the column value is extracted.</typeparam>

src/PolylineAlgorithm/PolylineDecoder.cs

@@ -38,6 +38,7 @@ public class PolylineDecoder<TPolyline, TCoordinate> : IPolylineDecoder<TPolylin
     /// <exception cref="ArgumentNullException">
     /// Thrown when <paramref name="options"/> is <see langword="null"/>.
     /// </exception>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Null is verified before use via ExceptionGuard.ThrowArgumentNull, which is annotated [DoesNotReturn]. CA1062 does not recognise custom [DoesNotReturn] helpers as null guards.")]
     public PolylineDecoder(PolylineOptions<TCoordinate, TPolyline> options) {
         if (options is null) {
             ExceptionGuard.ThrowArgumentNull(nameof(options));

src/PolylineAlgorithm/PolylineEncoder.cs

@@ -40,6 +40,7 @@ public class PolylineEncoder<TCoordinate, TPolyline> : IPolylineEncoder<TCoordin
     /// <exception cref="ArgumentNullException">
     /// Thrown when <paramref name="options"/> is <see langword="null"/>.
     /// </exception>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Null is verified before use via ExceptionGuard.ThrowArgumentNull, which is annotated [DoesNotReturn]. CA1062 does not recognise custom [DoesNotReturn] helpers as null guards.")]
     public PolylineEncoder(PolylineOptions<TCoordinate, TPolyline> options) {
         if (options is null) {
             ExceptionGuard.ThrowArgumentNull(nameof(options));

src/PolylineAlgorithm/PolylineItemFactory.cs

@@ -14,7 +14,7 @@ namespace PolylineAlgorithm;
 /// <typeparam name="T">The coordinate or item type to create.</typeparam>
 /// <param name="values">
 /// The scaled integer values accumulated from the polyline decoder. Each element corresponds to one
-/// column as defined by the <see cref="FormatterBuilder{T}"/> that built the associated formatter.
+/// column as defined by the <see cref="FormatterBuilder{TCoordinate, TPolyline}"/> that built the associated formatter.
 /// </param>
 /// <returns>A <typeparamref name="T"/> instance reconstructed from <paramref name="values"/>.</returns>
 public delegate T PolylineItemFactory<T>(ReadOnlySpan<long> values);

src/PolylineAlgorithm/PublicAPI.Unshipped.txt

@@ -38,9 +38,21 @@ PolylineAlgorithm.PolylineEncoder<TCoordinate, TPolyline>
 PolylineAlgorithm.PolylineEncoder<TCoordinate, TPolyline>.Encode(System.ReadOnlySpan<TCoordinate> coordinates, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> TPolyline
 PolylineAlgorithm.PolylineEncoder<TCoordinate, TPolyline>.PolylineEncoder(PolylineAlgorithm.PolylineOptions<TCoordinate, TPolyline>! options) -> void
 PolylineAlgorithm.Extensions.PolylineDecoderExtensions
+static PolylineAlgorithm.Extensions.PolylineDecoderExtensions.Decode<TValue>(this PolylineAlgorithm.Abstraction.IPolylineDecoder<string!, TValue>! decoder, char[]! polyline) -> System.Collections.Generic.IEnumerable<TValue>!
+static PolylineAlgorithm.Extensions.PolylineDecoderExtensions.Decode<TValue>(this PolylineAlgorithm.Abstraction.IPolylineDecoder<string!, TValue>! decoder, System.ReadOnlyMemory<char> polyline) -> System.Collections.Generic.IEnumerable<TValue>!
+static PolylineAlgorithm.Extensions.PolylineDecoderExtensions.Decode<TValue>(this PolylineAlgorithm.Abstraction.IPolylineDecoder<System.ReadOnlyMemory<char>, TValue>! decoder, string! polyline) -> System.Collections.Generic.IEnumerable<TValue>!
 PolylineAlgorithm.Extensions.PolylineEncoderExtensions
+static PolylineAlgorithm.Extensions.PolylineEncoderExtensions.Encode<TCoordinate, TPolyline>(this PolylineAlgorithm.Abstraction.IPolylineEncoder<TCoordinate, TPolyline>! encoder, System.Collections.Generic.List<TCoordinate>! coordinates) -> TPolyline
+static PolylineAlgorithm.Extensions.PolylineEncoderExtensions.Encode<TCoordinate, TPolyline>(this PolylineAlgorithm.Abstraction.IPolylineEncoder<TCoordinate, TPolyline>! encoder, TCoordinate[]! coordinates) -> TPolyline
 PolylineAlgorithm.InvalidPolylineException
 PolylineAlgorithm.InvalidPolylineException.InvalidPolylineException() -> void
-PolylineAlgorithm.InvalidPolylineException.InvalidPolylineException(string! message) -> void
 PolylineAlgorithm.InvalidPolylineException.InvalidPolylineException(string! message, System.Exception! innerException) -> void
 PolylineAlgorithm.PolylineEncoding
+static PolylineAlgorithm.PolylineEncoding.Normalize(double value, uint precision = 5) -> int
+static PolylineAlgorithm.PolylineEncoding.Denormalize(int value, uint precision = 5) -> double
+static PolylineAlgorithm.PolylineEncoding.TryReadValue(ref int delta, System.ReadOnlyMemory<char> buffer, ref int position) -> bool
+static PolylineAlgorithm.PolylineEncoding.TryWriteValue(int delta, System.Span<char> buffer, ref int position) -> bool
+static PolylineAlgorithm.PolylineEncoding.GetRequiredBufferSize(int delta) -> int
+static PolylineAlgorithm.PolylineEncoding.ValidateFormat(System.ReadOnlySpan<char> polyline) -> void
+static PolylineAlgorithm.PolylineEncoding.ValidateCharRange(System.ReadOnlySpan<char> polyline) -> void
+static PolylineAlgorithm.PolylineEncoding.ValidateBlockLength(System.ReadOnlySpan<char> polyline) -> void