lets just commit

Author: petesramek

.editorconfig

@@ -1,4 +1,4 @@
-# Remove the line below if you want to inherit .editorconfig settings from higher directories
+# Remove the line below if you want to inherit .editorconfig settings from higher directories
 root = true
 
 # All files
@@ -270,3 +270,7 @@ dotnet_naming_style.underscore_camel_case.required_prefix = _
 dotnet_naming_style.underscore_camel_case.required_suffix = 
 dotnet_naming_style.underscore_camel_case.word_separator = 
 dotnet_naming_style.underscore_camel_case.capitalization = camel_case
+
+# Public API analyzer
+
+dotnet_public_api_analyzer.require_api_files = true

PolylineAlgorithm.slnx

@@ -9,11 +9,9 @@
     <Project Path="samples/PolylineAlgorithm.NetTopologySuite.Sample/PolylineAlgorithm.NetTopologySuite.Sample.csproj" Id="27a8fc47-0a3c-49c7-af5e-530514827785" />
   </Folder>
   <Folder Name="/src/">
-    <Project Path="src/PolylineAlgorithm.Gps/PolylineAlgorithm.Gps.csproj" Id="816a7001-8faf-472e-8927-86286149a8d1" />
     <Project Path="src/PolylineAlgorithm/PolylineAlgorithm.csproj" />
   </Folder>
   <Folder Name="/tests/">
-    <Project Path="tests/PolylineAlgorithm.Gps.Tests/PolylineAlgorithm.Gps.Tests.csproj" />
     <Project Path="tests/PolylineAlgorithm.Tests/PolylineAlgorithm.Tests.csproj" />
   </Folder>
   <Folder Name="/utilities/" Id="02ea681e-c7d8-13c7-8484-4ac65e1b71e8">

benchmarks/PolylineAlgorithm.Benchmarks/PolylineAlgorithm.Benchmarks.csproj

@@ -25,7 +25,6 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<ProjectReference Include="..\..\src\PolylineAlgorithm.Gps\PolylineAlgorithm.Gps.csproj" />
 		<ProjectReference Include="..\..\src\PolylineAlgorithm\PolylineAlgorithm.csproj" />
 		<ProjectReference Include="..\..\utilities\PolylineAlgorithm.Utility\PolylineAlgorithm.Utility.csproj" />
 	</ItemGroup>

benchmarks/PolylineAlgorithm.Benchmarks/PolylineBenchmark.cs

@@ -7,8 +7,7 @@ namespace PolylineAlgorithm.Benchmarks;
 
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Engines;
-using PolylineAlgorithm.Gps;
-using PolylineAlgorithm.Gps.Extensions;
+using PolylineAlgorithm.Abstraction;
 using PolylineAlgorithm.Utility;
 
 /// <summary>
@@ -21,11 +20,6 @@ public class PolylineDecoderBenchmark {
     public int CoordinatesCount { get; set; }
 
 #pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring as nullable.
-    /// <summary>
-    /// Polyline instance for benchmarks.
-    /// </summary>
-    public Polyline Polyline { get; private set; }
-
     /// <summary>
     /// Encoded polyline as string.
     /// </summary>
@@ -44,37 +38,36 @@ public class PolylineDecoderBenchmark {
 #pragma warning restore CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring as nullable.
 
     /// <summary>
-    /// Polyline decoder instance.
+    /// String polyline decoder instance.
+    /// </summary>
+    private readonly StringPolylineDecoder _stringDecoder = new();
+
+    /// <summary>
+    /// Char array polyline decoder instance.
     /// </summary>
-    private readonly PolylineDecoder _decoder = new();
+    private readonly CharArrayPolylineDecoder _charArrayDecoder = new();
+
+    /// <summary>
+    /// String polyline decoder instance.
+    /// </summary>
+    private readonly MemoryCharPolylineDecoder _memoryCharDecoder = new();
 
     /// <summary>
     /// Sets up benchmark data.
     /// </summary>
     [GlobalSetup]
     public void SetupData() {
-        Polyline = Polyline.FromString(RandomValueProvider.GetPolyline(CoordinatesCount));
         String = RandomValueProvider.GetPolyline(CoordinatesCount);
         CharArray = RandomValueProvider.GetPolyline(CoordinatesCount).ToCharArray();
         Memory = RandomValueProvider.GetPolyline(CoordinatesCount).AsMemory();
     }
 
-    /// <summary>
-    /// Benchmark: decode polyline instance.
-    /// </summary>
-    [Benchmark]
-    public void PolylineDecoder_Decode_Polyline() {
-        _decoder
-            .Decode(Polyline)
-            .Consume(_consumer);
-    }
-
     /// <summary>
     /// Benchmark: decode from string.
     /// </summary>
     [Benchmark]
     public void PolylineDecoder_Decode_String() {
-        _decoder
+        _stringDecoder
             .Decode(String)
             .Consume(_consumer);
     }
@@ -84,7 +77,7 @@ public void PolylineDecoder_Decode_String() {
     /// </summary>
     [Benchmark]
     public void PolylineDecoder_Decode_CharArray() {
-        _decoder
+        _charArrayDecoder
             .Decode(CharArray)
             .Consume(_consumer);
     }
@@ -94,8 +87,38 @@ public void PolylineDecoder_Decode_CharArray() {
     /// </summary>
     [Benchmark]
     public void PolylineDecoder_Decode_Memory() {
-        _decoder
+        _memoryCharDecoder
             .Decode(Memory)
             .Consume(_consumer);
     }
+
+    private sealed class StringPolylineDecoder : AbstractPolylineDecoder<string, (double Latitude, double Longitude)> {
+        protected override (double Latitude, double Longitude) CreateCoordinate(double latitude, double longitude) {
+            return (latitude, longitude);
+        }
+
+        protected override ReadOnlyMemory<char> GetReadOnlyMemory(in string polyline) {
+            return polyline?.AsMemory() ?? Memory<char>.Empty;
+        }
+    }
+
+    private sealed class CharArrayPolylineDecoder : AbstractPolylineDecoder<char[], (double Latitude, double Longitude)> {
+        protected override (double Latitude, double Longitude) CreateCoordinate(double latitude, double longitude) {
+            return (latitude, longitude);
+        }
+
+        protected override ReadOnlyMemory<char> GetReadOnlyMemory(in char[] polyline) {
+            return polyline?.AsMemory() ?? Memory<char>.Empty;
+        }
+    }
+
+    private sealed class MemoryCharPolylineDecoder : AbstractPolylineDecoder<ReadOnlyMemory<char>, (double Latitude, double Longitude)> {
+        protected override (double Latitude, double Longitude) CreateCoordinate(double latitude, double longitude) {
+            return (latitude, longitude);
+        }
+
+        protected override ReadOnlyMemory<char> GetReadOnlyMemory(in ReadOnlyMemory<char> polyline) {
+            return polyline;
+        }
+    }
 }