fix: three bugs in create-release composite action (#199)

The release workflow's "Create GitHub Release" job was failing with
`unexpected EOF while looking for matching '"'` due to a quoting bug in
the composite action.

## Changes

- **Unmatched quote (root cause):** `notes-start-tag-argument` echo
placed the `${{ expr }}` *outside* the surrounding double-quotes. When
`notes-start-tag` is empty the expression expands to nothing, leaving a
bare `"` that bash can't match:
  ```bash
  # before — broken when expr is empty
  echo "notes-start-tag-argument="${{ ... }}"
  
  # after — expression inside the quotes
  echo "notes-start-tag-argument=${{ ... }}"
  ```

- **Wrong interpolation syntax in `notes-start-tag-argument` env:** Used
bash command-substitution syntax `$(inputs.notes-start-tag)` inside a GH
Actions expression — would have tried to shell-execute
`inputs.notes-start-tag` when the tag was non-empty. Replaced with
`format('--notes-start-tag {0}', inputs.notes-start-tag)`.

- **Wrong env reference in "Create git tag" step:** Referenced `${{
env.release-version }}` which is only scoped to the *next* step's `env:`
block, so it always resolved to empty. Changed to `${{
inputs.release-version }}`.

Author: Copilot

.github/actions/github/create-release/action.yml

@@ -23,18 +23,18 @@ runs:
         echo "is-preview=${{ inputs.is-preview }}"
         echo "preview-argument=${{ inputs.is-preview == 'true' && '--prerelease' || '' }}"
         echo "notes-start-tag=${{ inputs.notes-start-tag }}"
-        echo "notes-start-tag-argument="${{ inputs.notes-start-tag != '' && '--notes-start-tag $(inputs.notes-start-tag)' || '' }}"
+        echo "notes-start-tag-argument=${{ inputs.notes-start-tag != '' && format('--notes-start-tag {0}', inputs.notes-start-tag) || '' }}"
       shell: bash
-    - name: 'Create git tag ${{ env.release-version }}'
+    - name: 'Create git tag ${{ inputs.release-version }}'
       shell: bash
       run: |
-        git tag -a ${{ env.release-version }} -m "${{ env.release-version }}"
-    - name: 'Create GitHub release PolylineAlgorithm ${{ env.release-version }}'
+        git tag -a ${{ inputs.release-version }} -m "${{ inputs.release-version }}"
+    - name: 'Create GitHub release PolylineAlgorithm ${{ inputs.release-version }}'
       shell: bash
       env:
         GH_TOKEN: ${{ github.token }}
         release-version: ${{ inputs.release-version }}
         preview-argument: "${{ inputs.is-preview == 'true' && '--prerelease' || '' }}"
-        notes-start-tag-argument: "${{ inputs.notes-start-tag != '' && '--notes-start-tag $(inputs.notes-start-tag)' || '' }}"
+        notes-start-tag-argument: "${{ inputs.notes-start-tag != '' && format('--notes-start-tag {0}', inputs.notes-start-tag) || '' }}"
       run: |
         gh release create ${{ env.release-version }} --generate-notes --discussion-category "General" ${{ env.preview-argument }} ${{ env.notes-start-tag-argument }}