refactoring, simplification

Author: petesramek

benchmarks/PolylineAlgorithm.Benchmarks/PolylineBenchmark.cs

@@ -56,8 +56,8 @@ public class PolylineBenchmark {
     /// </summary>
     [GlobalSetup]
     public void SetupData() {
-        PolylineValue = RandomValueProvider.GetPolyline(Count);
-        PolylineNotEqualValue = RandomValueProvider.GetPolyline(Count + Random.Shared.Next(1, 101));
+        PolylineValue = Polyline.FromString(RandomValueProvider.GetPolyline(Count));
+        PolylineNotEqualValue = Polyline.FromString(RandomValueProvider.GetPolyline(Count + Random.Shared.Next(1, 101)));
         StringValue = PolylineValue.ToString();
         CharArrayValue = [.. StringValue];
         MemoryValue = CharArrayValue.AsMemory();

benchmarks/PolylineAlgorithm.Benchmarks/PolylineBuilderBenchmark.cs

@@ -31,14 +31,14 @@ public class PolylineDecoderBenchmark {
     /// <summary>
     /// The polyline decoder instance.
     /// </summary>
-    public PolylineDecoder Decoder = new();
+    public CoordinateDecoder Decoder = new();
 
     /// <summary>
     /// Sets up the data for the benchmarks.
     /// </summary>
     [GlobalSetup]
     public void SetupData() {
-        Polyline = RandomValueProvider.GetPolyline(Count);
+        Polyline = Polyline.FromString(RandomValueProvider.GetPolyline(Count));
     }
 
     /// <summary>

benchmarks/PolylineAlgorithm.Benchmarks/PolylineDecoderBenchmark.cs

@@ -33,14 +33,14 @@ public class PolylineEncoderBenchmark {
     /// <summary>
     /// The polyline encoder instance.
     /// </summary>
-    public PolylineEncoder Encoder = new();
+    public CoordinateEncoder Encoder = new();
 
     /// <summary>
     /// Sets up the data for the benchmarks.
     /// </summary>
     [GlobalSetup]
     public void SetupData() {
-        Enumeration = RandomValueProvider.GetCoordinates(Count);
+        Enumeration = RandomValueProvider.GetCoordinates(Count).Select(c => new Coordinate(c.Latitude, c.Longitude));
         List = [.. Enumeration];
     }
 

benchmarks/PolylineAlgorithm.Benchmarks/PolylineEncoderBenchmark.cs

@@ -6,9 +6,7 @@
 namespace PolylineAlgorithm.Benchmarks;
 
 using BenchmarkDotNet.Configs;
-using BenchmarkDotNet.Engines;
 using BenchmarkDotNet.Running;
-using Microsoft.CodeAnalysis;
 
 /// <summary>
 /// The main entry point for the benchmark application.

benchmarks/PolylineAlgorithm.Benchmarks/Program.cs

@@ -3,20 +3,17 @@
 using global::NetTopologySuite.Geometries;
 using PolylineAlgorithm.Abstraction;
 using System;
-using System.Buffers;
-
-internal class NetTopologyPolylineDecoder : PolylineDecoder<Point, string> {
-    public override PolylineEncodingOptions<Point> Options { get; } = new PolylineEncodingOptions<Point>();
 
+internal class NetTopologyPolylineDecoder : PolylineDecoder<string, Point> {
     protected override Point CreateCoordinate(double latitude, double longitude) {
         return new Point(latitude, longitude);
     }
 
-    protected override ReadOnlySequence<char> GetReadOnlySequence(string? polyline) {
+    protected override ReadOnlyMemory<char> GetReadOnlyMemory(string? polyline) {
         if (string.IsNullOrWhiteSpace(polyline)) {
             throw new ArgumentException("Value cannot be null, empty or whitespace.", nameof(polyline));
         }
 
-        return new(polyline.AsMemory());
+        return polyline.AsMemory();
     }
 }

samples/PolylineAlgorithm.NetTopologySuite.Sample/NetTopologyPolylineDecoder.cs

@@ -6,25 +6,13 @@
 using System.Text;
 
 internal class NetTopologyPolylineEncoder : PolylineEncoder<Point, string> {
-    public override PolylineEncodingOptions<Point> Options { get; } = new PolylineEncodingOptions<Point>();
 
-    protected override string CreatePolyline(ReadOnlySequence<char> sequence) {
-        if (sequence.IsEmpty) {
+    protected override string CreatePolyline(ReadOnlyMemory<char> polyline) {
+        if (polyline.IsEmpty) {
             return string.Empty;
         }
 
-        if (sequence.IsSingleSegment) {
-            return sequence.FirstSpan.ToString();
-        }
-
-        var enumerator = sequence.GetEnumerator();
-        var sb = new StringBuilder();
-
-        while (enumerator.MoveNext()) {
-            sb.Append(enumerator.Current);
-        }
-
-        return sb.ToString();
+        return polyline.ToString();
     }
 
     protected override double GetLatitude(Point? current) {

samples/PolylineAlgorithm.NetTopologySuite.Sample/NetTopologyPolylineEncoder.cs

@@ -10,7 +10,7 @@ namespace PolylineAlgorithm.Abstraction;
 /// <summary>
 /// Defines a contract for decoding an encoded polyline into a collection of geographic coordinates.
 /// </summary>
-public interface IPolylineDecoder<TCoordinate, TPolyline> {
+public interface IPolylineDecoder<TPolyline, TCoordinate> {
     /// <summary>
     /// Decodes the specified encoded polyline into a sequence of geographic coordinates.
     /// </summary>

src/PolylineAlgorithm.Abstraction/IPolylineDecoder.cs

@@ -1,9 +1,6 @@
 namespace PolylineAlgorithm.Abstraction;
 
-using PolylineAlgorithm.Abstraction.Validation.Abstraction;
-
-public interface IPolylineEncodingOptionsBuilder<TCoordinate> {
-    IPolylineEncodingOptionsBuilder<TCoordinate> WithBufferSize(int maxBufferSize);
-    IPolylineEncodingOptionsBuilder<TCoordinate> WithValidator(Validator<TCoordinate> validator);
-    PolylineEncodingOptions<TCoordinate> Build();
+public interface IPolylineEncodingOptionsBuilder {
+    IPolylineEncodingOptionsBuilder WithBufferSize(int maxBufferSize);
+    PolylineEncodingOptions Build();
 }