updated docs gen

Author: petesramek

.github/actions/docfx-metadata/action.yml

@@ -3,6 +3,9 @@ author: 'Pete Sramek'
 description: 'Generate metadata using docfx'
 inputs:
 # Required
+  artifact-name:
+    description: 'Name of the artifact to upload after generating documentation'
+    required: true
   docfx-json-manifest:
     description: 'Path to the docfx JSON manifest file'
     required: true
@@ -29,4 +32,9 @@ runs:
       shell: bash
     - name: 'Generate documentation'
       run: docfx metadata ${{ inputs.docfx-json-manifest }} --output ./api-reference/${{ inputs.assembly-version }}
-      shell: bash
+      shell: bash
+    - name: Upload artifact
+      uses: actions/upload-artifact@v4
+      with:
+        name: ${{ inputs.artifact-name }}
+        path: ${{ inputs.output-directory }}

.github/actions/push-changes/action.yml

@@ -12,14 +12,14 @@ inputs:
   commit-message:
     description: 'The commit message to use when pushing changes.'
     required: true
+  artifact-name:
+    description: 'Name of the artifact to download before pushing changes.'
+    required: true
 # Optional
   dotnet_sdk_version:
     description: '.NET SDK version. Default: 9.x'
     required: false
     default: '9.x'
-  artifact-name:
-    description: 'Name of the artifact to download before pushing changes.'
-    required: false
   force-checkout:
     description: 'Force checkout the target branch, discarding local changes.'
     required: false
@@ -34,7 +34,6 @@ runs:
       with:
         dotnet-version: ${{ env.dotnet-sdk-version }}
     - name: Download a single artifact
-      if: ${{ inputs.artifact-name != '' }}
       uses: actions/download-artifact@v4
       with:
         name: ${{ inputs.artifact-name }}

.github/workflows/build.yml

@@ -214,26 +214,29 @@ jobs:
       - name: 'Generate assembly metadata'
         uses: ./.github/actions/docfx-metadata
         with:
+          artifact-name: 'assembly-metadata'
           docfx-json-manifest: './api-reference/assembly-metadata.json'
           assembly-version: ${{ needs.versioning.outputs.friendly-version }}
           target-directory: './api-reference/${{ env.friendly-version }}/'
       - name: 'Push documentation to ${{ github.head_ref || github.ref }} branch'
         uses: ./.github/actions/push-changes
         with:
+          artifact-name: 'assembly-metadata'
           working-directory: './api-reference/'
           target-branch: ${{ github.head_ref || github.ref }}
           commit-message: 'Update docs for version ${{ env.friendly-version }}'
           force: false
-      - name: 'Generate assembly metadata'
+      - name: 'Generate documentation'
         uses: ./.github/actions/docfx-build
         with:
+          artifact-name: 'documentation'
           docfx-json-manifest: './api-reference/api-reference.json'
           assembly-version: ${{ needs.versioning.outputs.friendly-version }}
-          target-directory: './api-reference/${{ env.friendly-version }}/'
+          output-directory: './api-reference/'
       - name: Upload artifact
         uses: actions/upload-pages-artifact@v3
         with:
-          path: './docs'
+          path: './api-reference/_docs'
       - name: Deploy to GitHub Pages
         id: deployment
         uses: actions/deploy-pages@v4