imporvements

Author: petesramek

src/PolylineAlgorithm/Abstraction/AbstractPolylineEncoder.cs

@@ -92,6 +92,8 @@ public TPolyline Encode(ReadOnlySpan<TCoordinate> coordinates) {
 
         try {
             for (var i = 0; i < coordinates.Length; i++) {
+
+
                 delta
                     .Next(
                         PolylineEncoding.Normalize(GetLatitude(coordinates[i]), CoordinateValueType.Latitude),

src/PolylineAlgorithm/Coordinate.cs

@@ -14,6 +14,7 @@ namespace PolylineAlgorithm;
 using System.Text.Json.Serialization;
 #if NET8_0_OR_GREATER
 using System.Text;
+using System.Linq.Expressions;
 #endif
 
 /// <summary>
@@ -55,13 +56,8 @@ public Coordinate() {
     /// or when <paramref name="longitude"/> is less than -180 or greater than 180.
     /// </exception>
     public Coordinate(double latitude, double longitude) {
-        if (latitude < -90 || latitude > 90 || !double.IsFinite(latitude)) {
-            throw new ArgumentOutOfRangeException(nameof(latitude), string.Format(CultureInfo.InvariantCulture, _coordinateValueMustBeBetweenValuesMessageFormat, "Latitude", -90, 90));
-        }
-
-        if (longitude < -180 || longitude > 180 || !double.IsFinite(longitude)) {
-            throw new ArgumentOutOfRangeException(nameof(longitude), string.Format(CultureInfo.InvariantCulture, _coordinateValueMustBeBetweenValuesMessageFormat, "Longitude", -180, 180));
-        }
+        Validator.ValidateLatitude(latitude);
+        Validator.ValidateLongitude(longitude);
 
         Latitude = latitude;
         Longitude = longitude;
@@ -128,4 +124,35 @@ public override string ToString() {
     /// <see langword="true"/> if the coordinates are not equal; otherwise, <see langword="false"/>.
     /// </returns>
     public static bool operator !=(Coordinate left, Coordinate right) => !(left == right);
+
+    /// <summary>
+    /// Provides validation methods for latitude and longitude values used in <see cref="Coordinate"/>.
+    /// </summary>
+    internal static class Validator {
+        /// <summary>
+        /// Validates that the specified latitude is within the valid range of -90 to 90 degrees and is a finite value.
+        /// </summary>
+        /// <param name="latitude">The latitude value to validate.</param>
+        /// <exception cref="ArgumentOutOfRangeException">
+        /// Thrown when <paramref name="latitude"/> is less than -90, greater than 90, or not a finite value.
+        /// </exception>
+        internal static void ValidateLatitude(double latitude) {
+            if (latitude < -90 || latitude > 90 || !double.IsFinite(latitude)) {
+                throw new ArgumentOutOfRangeException(nameof(latitude), string.Format(CultureInfo.InvariantCulture, _coordinateValueMustBeBetweenValuesMessageFormat, "Latitude", -90, 90));
+            }
+        }
+
+        /// <summary>
+        /// Validates that the specified longitude is within the valid range of -180 to 180 degrees and is a finite value.
+        /// </summary>
+        /// <param name="longitude">The longitude value to validate.</param>
+        /// <exception cref="ArgumentOutOfRangeException">
+        /// Thrown when <paramref name="longitude"/> is less than -180, greater than 180, or not a finite value.
+        /// </exception>
+        internal static void ValidateLongitude(double longitude) {
+            if (longitude < -180 || longitude > 180 || !double.IsFinite(longitude)) {
+                throw new ArgumentOutOfRangeException(nameof(longitude), string.Format(CultureInfo.InvariantCulture, _coordinateValueMustBeBetweenValuesMessageFormat, "Longitude", -180, 180));
+            }
+        }
+    }
 }

src/PolylineAlgorithm/Internal/Defaults.cs

@@ -26,10 +26,6 @@ internal static class Logging {
     /// Contains default values and constants specific to the polyline encoding algorithm.
     /// </summary>
     internal static class Algorithm {
-        /// <summary>
-        /// The precision factor used to round coordinate values during polyline encoding.
-        /// </summary>
-        internal const int Precision = 100_000;
 
         /// <summary>
         /// The number of bits to shift during polyline encoding.
@@ -69,21 +65,6 @@ internal static class Latitude {
             /// The maximum valid latitude value.
             /// </summary>
             internal const double Max = 90.00000;
-
-            /// <summary>
-            /// Contains constants related to normalized latitude values.
-            /// </summary>
-            [SuppressMessage("Critical Code Smell", "S3218:Inner class members should not shadow outer class \"static\" or type members", Justification = "Internal use only.")]
-            internal static class Normalized {
-                /// <summary>
-                /// The minimum normalized latitude value.
-                /// </summary>
-                internal const int Min = (int)(Latitude.Min * Algorithm.Precision);
-                /// <summary>
-                /// The maximum normalized latitude value.
-                /// </summary>
-                internal const int Max = (int)(Latitude.Max * Algorithm.Precision);
-            }
         }
 
         /// <summary>
@@ -102,21 +83,6 @@ internal static class Longitude {
             /// The maximum valid longitude value.
             /// </summary>
             internal const double Max = 180.00000;
-
-            /// <summary>
-            /// Contains constants related to normalized longitude values.
-            /// </summary>
-            [SuppressMessage("Critical Code Smell", "S3218:Inner class members should not shadow outer class \"static\" or type members", Justification = "Internal use only.")]
-            internal static class Normalized {
-                /// <summary>
-                /// The minimum normalized latitude value.
-                /// </summary>
-                internal const int Min = (int)(Longitude.Min * Algorithm.Precision);
-                /// <summary>
-                /// The maximum normalized latitude value.
-                /// </summary>
-                internal const int Max = (int)(Longitude.Max * Algorithm.Precision);
-            }
         }
     }
 
@@ -129,18 +95,18 @@ internal static class Polyline {
         /// </summary>
         internal static class Block {
             /// <summary>
-            /// Contains constants related to the length of encoded coordinates in polyline encoding.
+            /// Contains constants related to the length of encoded vakues in polyline encoding.
             /// </summary>
             internal static class Length {
                 /// <summary>
-                /// The minimum number of characters required to represent an encoded coordinate.
+                /// The minimum number of characters required to represent an encoded value.
                 /// </summary>
                 internal const int Min = 2;
 
                 /// <summary>
-                /// The maximum number of characters allowed to represent an encoded coordinate.
+                /// The maximum number of characters allowed to represent an encoded value.
                 /// </summary>
-                internal const int Max = 12;
+                internal const int Max = 14;
             }
         }
     }