Change Encode parameter from ReadOnlySpan<TValue> to IEnumerable<TValue>#236
Merged
petesramek merged 3 commits intoextend-polylinealgorithm-multi-dimensional-supportfrom Apr 13, 2026
Conversation
…umerable<TValue> Agent-Logs-Url: https://github.com/petesramek/polyline-algorithm-csharp/sessions/1e44410f-3278-4281-b17f-cdb7c9fd2078 Co-authored-by: petesramek <2333452+petesramek@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
petesramek
April 13, 2026 16:42
View session
…n PolylineEncoder Agent-Logs-Url: https://github.com/petesramek/polyline-algorithm-csharp/sessions/9ad635cf-efe4-4650-86cc-0083af3375f7 Co-authored-by: petesramek <2333452+petesramek@users.noreply.github.com>
Agent-Logs-Url: https://github.com/petesramek/polyline-algorithm-csharp/sessions/9ad635cf-efe4-4650-86cc-0083af3375f7 Co-authored-by: petesramek <2333452+petesramek@users.noreply.github.com>
petesramek
approved these changes
Apr 13, 2026
petesramek
merged commit a148b15
into
extend-polylinealgorithm-multi-dimensional-support
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IReadOnlyList<TValue>materialization with directforeach+anyItemProcessedflagstackalloc char[StackAllocLimit]→ double-and-rent fromArrayPoolon overflow)long[]scratch arrays withstackalloc long[MaxStackWidth]sliced to[..width]EncodeCore(both overloads delegate to it)SeedPreviousto acceptSpan<long>instead oflong[]GetMaxBufferLengthhasItems→anyItemProcessedfor clarity