[BUG FIXES] const qualify PFAC_readPatternFromFile() filename, update to __ballot_sync to support newer GPU architectures#8
Open
Arleee1 wants to merge 2 commits intopfac-lib:masterfrom
Conversation
Arleee1
force-pushed
the
string_const_and_ballot
branch
from
4d7db15 to
4644033
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Const qualify filename parameter of
PFAC_readPatternFromFile( PFAC_handle_t handle, const char *filename ). This allows it to take in strings without using strcpy() first.Replaces all
__ballot(predicate)cuda calls with__ballot_sync(__activemask(), predicate)to remove deprecated __ballot calls. __ballot no longer works on SM_70 and higher architectures, while__ballot_sync(__activemask(), predicate)retains the same functionality.Does not change existing functionality.