Adding feature to use custom "default_value" as filler for intervals …#17
Merged
Conversation
…that are not included in the bigwig files. The default is 0.0, which is consistent with the previous behavior. Now any custom value may be used, like cp.nan.
|
Thanks for making this update! I just checked and it seems that the behavior is unexpected when the first bin in the batch has missing values in the bigwig. In that case, it seems to return 0 instead of default_value. |
Collaborator
Author
|
@mukamel-lab thanks so much for pointing this out. So I still made a mistake somewhere. Need to include a test that simulates this scenario. Will look into it. |
Collaborator
Author
|
@mukamel-lab . I am trying to replicate what you are seeing in this PR: #18 . I just don't manage to replicate it (see my comments in the PR). Could you maybe tell me exactly what call you are making, with which parameters? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…that are not included in the bigwig files. The default is 0.0, which is consistent with the previous behavior. Now any custom value may be used, like cp.nan.