Skip to content

Commit 2b3411d

Browse files
tests: remove defaultleasetime and maxleasetime from DHCPServerAddressPool kea tests
These fields are currently not available for Kea, but remain for ISC DHCP
1 parent 7028bd0 commit 2b3411d

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsDHCPServerAddressPoolTestCase.inc

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -360,8 +360,6 @@ class APIModelsDHCPServerAddressPoolTestCase extends TestCase {
360360
mac_allow: ['00:11:22:33:44:55'],
361361
mac_deny: ['55:44:33:22:11:00'],
362362
domainsearchlist: ['example.com'],
363-
defaultleasetime: 7201,
364-
maxleasetime: 86401,
365363
gateway: '192.168.1.2',
366364
dnsserver: ['127.0.0.53'],
367365
ntpserver: ['127.0.0.123'],
@@ -374,8 +372,6 @@ class APIModelsDHCPServerAddressPoolTestCase extends TestCase {
374372
$kea_json = json_decode($kea_conf, associative: true);
375373
$kea_pool = $kea_json['Dhcp4']['subnet4'][0]['pools'][1];
376374
$this->assert_equals($kea_pool['pool'], $pool->range_from->value . ' - ' . $pool->range_to->value);
377-
$this->assert_equals($kea_pool['valid-lifetime'], (string) $pool->defaultleasetime->value);
378-
$this->assert_equals($kea_pool['max-valid-lifetime'], (string) $pool->maxleasetime->value);
379375
$this->assert_equals(
380376
$this->get_kea_option_by_name('domain-name-servers', $kea_pool['option-data']),
381377
$pool->dnsserver->value[0],
@@ -403,8 +399,6 @@ class APIModelsDHCPServerAddressPoolTestCase extends TestCase {
403399
mac_allow: ['55:44:33:22:11:00'],
404400
mac_deny: ['00:11:22:33:44:55'],
405401
domainsearchlist: ['new.example.com'],
406-
defaultleasetime: 7205,
407-
maxleasetime: 86405,
408402
gateway: '192.168.1.5',
409403
dnsserver: ['127.0.1.53'],
410404
ntpserver: ['127.0.1.123'],
@@ -416,8 +410,6 @@ class APIModelsDHCPServerAddressPoolTestCase extends TestCase {
416410
$kea_json = json_decode($kea_conf, associative: true);
417411
$kea_pool = $kea_json['Dhcp4']['subnet4'][0]['pools'][1];
418412
$this->assert_equals($kea_pool['pool'], $pool->range_from->value . ' - ' . $pool->range_to->value);
419-
$this->assert_equals($kea_pool['valid-lifetime'], (string) $pool->defaultleasetime->value);
420-
$this->assert_equals($kea_pool['max-valid-lifetime'], (string) $pool->maxleasetime->value);
421413
$this->assert_equals(
422414
$this->get_kea_option_by_name('domain-name-servers', $kea_pool['option-data']),
423415
$pool->dnsserver->value[0],

0 commit comments

Comments
 (0)