fix: don't check wg peer key format if it's empty #581

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/WireGuardPeer.inc

@@ -94,7 +94,7 @@ class WireGuardPeer extends Model {
      */
     public function validate_presharedkey(string $presharedkey): string {
         # Throw an error if this value is not a valid WireGuard key
-        if (!wg_is_valid_key($presharedkey)) {
+        if ($presharedkey and !wg_is_valid_key($presharedkey)) {
             throw new ValidationError(
                 message: 'Field `presharedkey` must be a valid WireGuard pre-shared key.',
                 response_id: 'WIREGUARD_PEER_PRESHAREDKEY_INVALID',

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsWireGuardPeerTestCase.inc

@@ -50,6 +50,14 @@ class APIModelsWireGuardPeerTestCase extends TestCase {
                 $peer->validate();
             },
         );
+
+        # Ensure empty PSK does not throw an error
+        $this->assert_does_not_throw(
+            callable: function () {
+                $peer = new WireGuardPeer(publickey: 'KG0BA4UyPilHH5qnXCfr6Lw8ynecOPor88tljLy3AHk=', presharedkey: '');
+                $peer->validate();
+            },
+        );
     }
 
     /**