fix: clear gateway cache before applying routing changes

pfSense 2.8.0 adds a new backend GatewaysCache that is not automatically kept up-to-date. This means there can be a conflict between the current configuration and the cache when the routing subsystem is applied which can result in duplicate or unintentional routing changes. This change clears the cache before we apply routing changes to ensure its always up-to-date with the config

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Dispatchers/RoutingApplyDispatcher.inc

@@ -15,10 +15,12 @@ class RoutingApplyDispatcher extends Dispatcher {
     public function process(...$arguments): void {
         global $g;
 
+        # Clear the gateway cache to ensure the latest status is fetched during routing changes
+        unset($GLOBALS['GatewaysCache']);
+
         # Check for the pending changes file and unserialize it
         if (file_exists("{$g['tmp_path']}/.system_routes.apply")) {
             $to_apply_list = unserialize(file_get_contents("{$g['tmp_path']}/.system_routes.apply"));
-
             # Run commands to apply these changes
             foreach ($to_apply_list as $to_apply) {
                 mwexec("{$to_apply}");