fix(UIDField): use default callable to generate default instead of a fixed default

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Fields/UIDField.inc

@@ -40,7 +40,7 @@ class UIDField extends RESTAPI\Core\Field {
      * @param string $help_text Set a description for this field. This description will be used in API documentation.
      */
     public function __construct(
-        string $prefix = '',
+        public string $prefix = '',
         bool $sensitive = false,
         bool $representation_only = false,
         string $verbose_name = '',
@@ -55,7 +55,7 @@ class UIDField extends RESTAPI\Core\Field {
         parent::__construct(
             type: 'string',
             unique: true,
-            default: uniqid(prefix: $prefix),
+            default_callable: 'generate_uid',
             editable: false,
             read_only: true,
             sensitive: $sensitive,
@@ -71,6 +71,10 @@ class UIDField extends RESTAPI\Core\Field {
         );
     }
 
+    public function generate_uid(): string {
+        return uniqid(prefix: $this->prefix);
+    }
+
     /**
      * Converts the field value to its representation form from it's internal pfSense configuration value.
      * @param mixed $internal_value The internal value from the pfSense configuration.

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIFieldsUIDFieldTestCase.inc

@@ -12,14 +12,23 @@ class APIFieldsUIDFieldTestCase extends TestCase {
     public function test_default(): void {
         $field1 = new UIDField();
         $field2 = new UIDField();
-        $this->assert_not_equals($field1->default, $field2->default);
+        $this->assert_not_equals($field1->get_default(), $field2->get_default());
     }
 
     /**
      * Checks that the 'prefix' attributes works as intended.
      */
     public function test_prefix(): void {
         $field = new UIDField(prefix: 'test-');
-        $this->assert_is_true(str_starts_with($field->default, 'test-'));
+        $this->assert_is_true(str_starts_with($field->get_default(), 'test-'));
+    }
+
+    /**
+     * Checks that the generate_uid method correctly generates a UID
+     */
+    public function test_generate_uid(): void {
+        $field = new UIDField();
+        $this->assert_is_not_empty($field->generate_uid());
+        $this->assert_not_equals($field->generate_uid(), $field->generate_uid());
     }
 }