fix(RESTAPIVersionReleasesCache): don't cache bad gh api responses #900

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Caches/RESTAPIVersionReleasesCache.inc

@@ -32,7 +32,16 @@ class RESTAPIVersionReleasesCache extends Cache {
         );
         $releases = json_decode($releases_json, true);
 
-        # Return the fetched releases if in a valid format, otherwise retain the existing cache
-        return is_array($releases) ? $releases : $this->read();
+        # If we don't have an 'assets' key, the response is invalid. Log the response, keep the existing cache
+        if (!is_array($releases) or !array_key_exists('assets', $releases)) {
+            Cache::log(
+                level: LOG_ERR,
+                message: "Releases data is malformed, received $releases_json. Keeping existing cache.",
+            );
+            return $this->read();
+        }
+
+        # Return the fetched releases
+        return $releases;
     }
 }