Skip to content

Week 1 : pgr_makeMaximalPlanar#554

Open
Mohit242-bit wants to merge 4 commits into
pgRouting:mohit-2026-maximal-planarfrom
Mohit242-bit:week1-maximal-planar
Open

Week 1 : pgr_makeMaximalPlanar#554
Mohit242-bit wants to merge 4 commits into
pgRouting:mohit-2026-maximal-planarfrom
Mohit242-bit:week1-maximal-planar

Conversation

@Mohit242-bit
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 28, 2026 17:10
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0341616d-4f48-4174-9afc-a8e470c3bf0c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds SQL-level declarations for a new planar module function pgr_makeMaximalPlanar (plus its internal _pgr_ C entry point) intended to expose maximal planar graph generation through the pgRouting extension.

Changes:

  • Introduces public SQL wrapper pgr_makeMaximalPlanar(TEXT) returning (seq, start_vid, end_vid).
  • Introduces internal C-backed function declaration _pgr_makeMaximalPlanar(TEXT) returning the same record shape.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
sql/planar/makeMaximalPlanar.sql Adds the public SQL wrapper and user-facing COMMENT metadata for pgr_makeMaximalPlanar.
sql/planar/_makeMaximalPlanar.sql Adds the internal C-function SQL declaration _pgr_makeMaximalPlanar intended to be implemented in the shared library.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sql/planar/makeMaximalPlanar.sql
Comment thread sql/planar/_makeMaximalPlanar.sql
Comment thread sql/planar/_makeMaximalPlanar.sql Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants