Dag shortestpath using the shortest path process and driver

[cvvergara]

Fixes #3060

Changes proposed in this pull request:

• Makes pgr_dagShortestPath to use the shortest_path driver/process
• Removes unused code of pgr_dagShortestPath because of the change
• Updates news and release notes about the change

@pgRouting/admins

Summary by CodeRabbit

Release Notes

• Enhancements

  • dagShortestPath now uses the shortest_path process and driver for improved consistency and algorithm handling.

• Documentation

  • Updated release notes for pgRouting 4.1.0.
  • Enhanced localization support for dagShortestPath documentation.

[coderabbitai]

Walkthrough

The PR refactors dagShortestPath to standardize its implementation by adopting the shared shortest_path process and driver architecture. This involves adding a DAGSP enum value, creating a public function wrapper, removing the algorithm-specific driver implementation, and integrating dagShortestPath dispatch cases into the unified shortestPath_driver.

Changes

Cohort / File(s)	Summary
Documentation & Release Notes NEWS.md, doc/src/release_notes.rst, locale/en/LC_MESSAGES/pgrouting_doc_strings.po, locale/pot/pgrouting_doc_strings.pot	Added release notes and localization entries documenting that dagShortestPath now uses the shortest_path process and driver (issue #3060).
Enum Enhancement include/c_common/enums.h	Added DAGSP enum member to the Which enumeration after EDWARDMOORE, enabling the unified driver dispatch mechanism.
Public API & Headers include/dagShortestPath/dagShortestPath.hpp	Added a new public template function dagShortestPath as a wrapper around the underlying Pgr_dag::dag logic, delegating graph computation and returning results.
Driver Consolidation include/drivers/dagShortestPath/dagShortestPath_driver.h, src/dagShortestPath/dagShortestPath_driver.cpp	Removed the algorithm-specific driver header and C++ implementation, consolidating functionality into the shared shortest_path process.
Core Implementation src/dagShortestPath/dagShortestPath.c	Refactored to invoke pgr_process_shortestPath instead of the removed pgr_do_dagShortestPath, passing appropriate arguments (DAGSP enum, configuration flags); removed old static helper and adjusted includes.
Build Configuration src/dagShortestPath/CMakeLists.txt	Removed dagShortestPath_driver.cpp from the library sources, leaving only dagShortestPath.c.
Unified Driver Integration src/cpp_common/utilities.cpp, src/dijkstra/shortestPath_driver.cpp	Extended get_name and estimate_drivingSide utilities to handle DAGSP; added DAGSP cases in shortestPath_driver.cpp to dispatch dagShortestPath calls for both directed and undirected graphs.
Test Enhancement pgtap/others/dagShortestPath/no_crash_test.pg	Updated version target and added error-path test coverage for empty edges scenario.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Using enumeration on existing drivers #3050: Establishes the enum-based driver/process refactoring foundation that this PR extends by adding DAGSP dispatch to the unified shortest_path architecture.
• Bd dijkstra using the shortest path process and driver #3057: Applies the same refactoring pattern to bdDijkstra, moving algorithm-specific drivers to the shared shortest_path process with analogous Which enum and driver dispatch changes.
• Edward moore using the shortest path process and driver #3059: Implements parallel standardization for edwardMoore using the same unified process/driver pattern with enum values and dispatch integration.

Suggested labels

Enhancement, C/C++, Function/Internal, Remove

Suggested reviewers

• robe2
• sanak

Poem

🐰 A rabbit hops with glee and cheer,
As drivers merge and paths are clear,
With DAGSP now unified and bright,
The shortest paths shine day and night! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: refactoring dagShortestPath to use the shortest_path process and driver.
Linked Issues check	✅ Passed	All code changes align with issue #3060: dagShortestPath now uses the shortest_path process/driver, removing old implementation.
Out of Scope Changes check	✅ Passed	All changes are in scope: refactoring dagShortestPath, adding DAGSP enum, updating documentation, and modifying related files per the objective.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@include/dagShortestPath/dagShortestPath.hpp`:
- Around line 221-234: The dagShortestPath wrapper's combinations parameter is
mutable but Pgr_dag<G>::dag expects a const std::map& and peer wrappers like
edwardMoore use const; change the signature of dagShortestPath to accept const
std::map<int64_t, std::set<int64_t>> &combinations (and update any local uses
accordingly) so the call to fn_dag.dag(graph, combinations, only_cost) matches
the const-correct API of Pgr_dag::dag and keeps the wrapper consistent with
edwardMoore.