From 45b0a2148dc2bff8ba271d1c16b2f12166483542 Mon Sep 17 00:00:00 2001 From: Mohit242-bit Date: Tue, 17 Feb 2026 17:47:28 +0000 Subject: [PATCH] clang-tidy: fix cppcoreguidelines-use-default-member-init --- .clang-tidy | 3 +-- include/bdAstar/bdAstar.hpp | 8 +++----- include/chinese/chinesePostman.hpp | 6 +++--- include/contraction/contractionGraph.hpp | 5 ++--- include/cpp_common/bidirectional.hpp | 5 ++--- include/visitors/dijkstra_visitors.hpp | 3 +-- include/vrp/solution.hpp | 4 +--- include/yen/ksp.hpp | 12 ++++-------- src/pickDeliver/solution.cpp | 1 - 9 files changed, 17 insertions(+), 30 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index c9920739c9..ed26c65812 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -24,8 +24,7 @@ Checks: > -cppcoreguidelines-pro-type-reinterpret-cast, -cppcoreguidelines-pro-type-union-access, -cppcoreguidelines-pro-type-vararg, - -cppcoreguidelines-slicing, - -cppcoreguidelines-use-default-member-init + -cppcoreguidelines-slicing CheckOptions: - key: cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor diff --git a/include/bdAstar/bdAstar.hpp b/include/bdAstar/bdAstar.hpp index a526b89722..691ec78198 100644 --- a/include/bdAstar/bdAstar.hpp +++ b/include/bdAstar/bdAstar.hpp @@ -72,9 +72,7 @@ class Pgr_bdAstar : public Pgr_bidirectional { public: explicit Pgr_bdAstar(G &pgraph) : - Pgr_bidirectional(pgraph), - m_heuristic(5), - m_factor(1.0) { + Pgr_bidirectional(pgraph) { m_log << "pgr_bdAstar constructor\n"; } @@ -184,8 +182,8 @@ class Pgr_bdAstar : public Pgr_bidirectional { } private: - int m_heuristic; - double m_factor; + int m_heuristic{5}; + double m_factor{1.0}; }; } // namespace bidirectional diff --git a/include/chinese/chinesePostman.hpp b/include/chinese/chinesePostman.hpp index 3937272410..52fdaeb46b 100644 --- a/include/chinese/chinesePostman.hpp +++ b/include/chinese/chinesePostman.hpp @@ -74,8 +74,8 @@ class PgrDirectedChPPGraph { void setPathEdges(graph::PgrCostFlowGraph &flowGraph); private: - int64_t totalDeg; - double totalCost; + int64_t totalDeg{0}; + double totalCost{0}; int64_t superSource, superTarget; int64_t startPoint; double m_cost; @@ -110,7 +110,7 @@ PgrDirectedChPPGraph::~PgrDirectedChPPGraph() { edgeToIdx.clear(); } PgrDirectedChPPGraph::PgrDirectedChPPGraph(const std::vector &dataEdges) : - totalDeg(0), totalCost(0), vertices(), + vertices(), edgeToIdx(), originalEdges(), resultGraph(), VToVecid(), edgeVisited(), pathStack(), resultPath(), diff --git a/include/contraction/contractionGraph.hpp b/include/contraction/contractionGraph.hpp index 431a7e2691..5a61299ada 100644 --- a/include/contraction/contractionGraph.hpp +++ b/include/contraction/contractionGraph.hpp @@ -66,8 +66,7 @@ class Pgr_contractionGraph : public Pgr_base_graph(), - min_edge_id(0) { + : Pgr_base_graph() { } /*! @brief get the vertex descriptors of adjacent vertices of *v* @@ -548,7 +547,7 @@ class Pgr_contractionGraph : public Pgr_base_graph forbiddenVertices; }; diff --git a/include/cpp_common/bidirectional.hpp b/include/cpp_common/bidirectional.hpp index e3741c2dd6..76b748d8cf 100644 --- a/include/cpp_common/bidirectional.hpp +++ b/include/cpp_common/bidirectional.hpp @@ -73,8 +73,7 @@ class Pgr_bidirectional { public: explicit Pgr_bidirectional(G &pgraph): graph(pgraph), - INF((std::numeric_limits::max)()), - best_cost(0) { + INF((std::numeric_limits::max)()) { m_log << "constructor\n"; } @@ -222,7 +221,7 @@ class Pgr_bidirectional { double INF; //!< infinity - double best_cost; + double best_cost{0}; mutable std::ostringstream m_log; Priority_queue forward_queue; diff --git a/include/visitors/dijkstra_visitors.hpp b/include/visitors/dijkstra_visitors.hpp index 0f9f5faa09..cbcd5325e8 100644 --- a/include/visitors/dijkstra_visitors.hpp +++ b/include/visitors/dijkstra_visitors.hpp @@ -147,7 +147,6 @@ class dijkstra_distance_visitor_no_init : public boost::default_dijkstra_visitor std::vector &color_map) : m_root(root), m_distance_goal(distance_goal), - m_num_examined(0), m_predecessors(predecessors), m_dist(distances), m_color(color_map) { @@ -190,7 +189,7 @@ class dijkstra_distance_visitor_no_init : public boost::default_dijkstra_visitor private: V m_root; double m_distance_goal; - size_t m_num_examined; + size_t m_num_examined{0}; std::vector &m_predecessors; std::vector &m_dist; std::vector &m_color; diff --git a/include/vrp/solution.hpp b/include/vrp/solution.hpp index 96ce55f87f..edbf60db6a 100644 --- a/include/vrp/solution.hpp +++ b/include/vrp/solution.hpp @@ -46,7 +46,7 @@ class Solution { friend class Optimize; friend class PD_problem; protected: - double EPSILON; + double EPSILON{0.0001}; std::deque fleet; /* this solution belongs to this problem*/ @@ -66,14 +66,12 @@ class Solution { /* @brief copy constructor */ Solution(const Solution &sol) : - EPSILON(0.0001), fleet(sol.fleet), trucks(sol.trucks) {}; /* @brief copy assignment */ Solution& operator = (const Solution& sol) { - EPSILON = 0.0001; fleet = sol.fleet; trucks = sol.trucks; return *this; diff --git a/include/yen/ksp.hpp b/include/yen/ksp.hpp index 8875227f75..93398f77f8 100644 --- a/include/yen/ksp.hpp +++ b/include/yen/ksp.hpp @@ -60,10 +60,6 @@ class Pgr_ksp : public Pgr_messages { public: Pgr_ksp() : - m_start(0), - m_end(0), - m_K(0), - m_heap_paths(false), m_vis(std::make_unique()) { } @@ -240,10 +236,10 @@ class Pgr_ksp : public Pgr_messages { ///@{ V v_source; //!< source descriptor V v_target; //!< target descriptor - int64_t m_start; //!< source id - int64_t m_end; //!< target id - size_t m_K; - bool m_heap_paths; + int64_t m_start{0}; //!< source id + int64_t m_end{0}; //!< target id + size_t m_K{0}; + bool m_heap_paths{false}; Path curr_result_path; //!< storage for the current result diff --git a/src/pickDeliver/solution.cpp b/src/pickDeliver/solution.cpp index 57ca6f0be2..cec7ae5836 100644 --- a/src/pickDeliver/solution.cpp +++ b/src/pickDeliver/solution.cpp @@ -230,7 +230,6 @@ Solution::get_kind() const { } Solution::Solution() : - EPSILON(0.0001), trucks(problem->trucks()) { ENTERING(msg()); for (const auto &t : trucks) {