From 1bec453bfe7cd53cfcf77edd0de93418d033c7c0 Mon Sep 17 00:00:00 2001 From: Ranjodh Singh Date: Tue, 24 Feb 2026 22:54:24 +0530 Subject: [PATCH] clang-tidy: check and fix cppcoreguidelines-avoid-c-arrays --- .clang-tidy | 1 - src/common/assert.cpp | 9 +++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 0936994542..aa9f598740 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -7,7 +7,6 @@ Checks: > -clang-analyzer-core.uninitialized.Assign, clang-diagnostic-*, cppcoreguidelines-*, - -cppcoreguidelines-avoid-c-arrays, -cppcoreguidelines-avoid-const-or-ref-data-members, -cppcoreguidelines-avoid-do-while, -cppcoreguidelines-avoid-magic-numbers, diff --git a/src/common/assert.cpp b/src/common/assert.cpp index c491821514..98000e1c2b 100644 --- a/src/common/assert.cpp +++ b/src/common/assert.cpp @@ -35,18 +35,19 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. #include #endif +#include #include #include std::string get_backtrace() { #ifdef __GLIBC__ - void *trace[16]; + const int max_trace_size = 16; + std::array trace{}; int i = 0, trace_size = 0; - trace_size = backtrace(trace, 16); - char** funcNames = backtrace_symbols(trace, trace_size); - + trace_size = backtrace(trace.data(), max_trace_size); + char** funcNames = backtrace_symbols(trace.data(), trace_size); std::string message = "\n*** Execution path***\n"; for (i = 0; i < trace_size; ++i) {