Fixed an issue where the default fillfactor value for B-tree indexes was incorrect. #9648

Author: pravesh-sharma

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/11_plus/create_btree_desc_null_first.sql

@@ -6,5 +6,5 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
     ON public.test_table_for_indexes USING btree
     (id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
     INCLUDE(name, id)
-    WITH (fillfactor=100)
+    WITH (fillfactor=90)
     TABLESPACE pg_default;

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/13_plus/alter_reset_fillfactor_cluster.sql

@@ -6,7 +6,7 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx1_$%{}[]()&*^!@""'`\/#"
     ON public.test_table_for_indexes USING btree
     (id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
     INCLUDE(name, id)
-    WITH (fillfactor=100, deduplicate_items=True)
+    WITH (fillfactor=90, deduplicate_items=True)
     TABLESPACE pg_default;
 
 COMMENT ON INDEX public."Idx1_$%{}[]()&*^!@""'`\/#"

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/13_plus/create_btree_desc_null_first.sql

@@ -6,5 +6,5 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
     ON public.test_table_for_indexes USING btree
     (id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
     INCLUDE(name, id)
-    WITH (fillfactor=100, deduplicate_items=True)
+    WITH (fillfactor=90, deduplicate_items=True)
     TABLESPACE pg_default;

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/15_plus/alter_reset_fillfactor_cluster.sql

@@ -7,7 +7,7 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx1_$%{}[]()&*^!@""'`\/#"
     (id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
     INCLUDE(name, id)
     NULLS NOT DISTINCT
-    WITH (fillfactor=100, deduplicate_items=True)
+    WITH (fillfactor=90, deduplicate_items=True)
     TABLESPACE pg_default;
 
 COMMENT ON INDEX public."Idx1_$%{}[]()&*^!@""'`\/#"

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/15_plus/create_btree_desc_null_first.sql

@@ -7,5 +7,5 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
     (id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
     INCLUDE(name, id)
     NULLS NOT DISTINCT
-    WITH (fillfactor=100, deduplicate_items=True)
+    WITH (fillfactor=90, deduplicate_items=True)
     TABLESPACE pg_default;

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/default/create_hash_index.sql

@@ -5,4 +5,5 @@
 CREATE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
     ON public.test_table_for_indexes USING hash
     (id)
+    WITH (fillfactor=90)
     TABLESPACE pg_default;

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/indexes/sql/11_plus/properties.sql

@@ -42,8 +42,10 @@ SELECT DISTINCT ON (cls.relname)
     COALESCE(
         substring(array_to_string(cls.reloptions, ',') FROM 'fillfactor=([0-9]*)')::int,
         CASE am.amname
-            WHEN 'btree' THEN 100
-            WHEN 'gist'  THEN 90
+            WHEN 'btree' THEN 90
+            WHEN 'gist' THEN 90
+            WHEN 'hash' THEN 90
+            WHEN 'spgist' THEN 90
             ELSE NULL
         END
     ) AS fillfactor,

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/indexes/sql/13_plus/properties.sql

@@ -48,8 +48,10 @@ SELECT DISTINCT ON (cls.relname)
     COALESCE(
         substring(array_to_string(cls.reloptions, ',') FROM 'fillfactor=([0-9]*)')::int,
         CASE am.amname
-            WHEN 'btree' THEN 100
+            WHEN 'btree' THEN 90
             WHEN 'gist' THEN 90
+            WHEN 'hash' THEN 90
+            WHEN 'spgist' THEN 90
             ELSE NULL
         END
     ) AS fillfactor,

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/indexes/sql/15_plus/properties.sql

@@ -49,8 +49,10 @@ SELECT DISTINCT ON (cls.relname)
     COALESCE(
         substring(array_to_string(cls.reloptions, ',') FROM 'fillfactor=([0-9]*)')::int,
         CASE am.amname
-            WHEN 'btree' THEN 100
+            WHEN 'btree' THEN 90
             WHEN 'gist' THEN 90
+            WHEN 'hash' THEN 90
+            WHEN 'spgist' THEN 90
             ELSE NULL
         END
     ) AS fillfactor,