Skip to content

Commit 7ef309a

Browse files
Fixed review comments and failing test cases
1 parent 4569799 commit 7ef309a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/13_plus/create_btree_desc_null_first.sql

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,4 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
66
ON public.test_table_for_indexes USING btree
77
(id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
88
INCLUDE(name, id)
9-
WITH (fillfactor=90, deduplicate_items=True)
109
TABLESPACE pg_default;

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -899,7 +899,8 @@ def _get_resql_for_rules(self, tid, main_sql, table, json_resp):
899899
main_sql.append(rules_sql)
900900

901901
def _get_resql_for_partitions(self, data, rset, json_resp,
902-
diff_partition_sql, main_sql, did):
902+
diff_partition_sql, main_sql, did,
903+
show_default_values):
903904
"""
904905
##########################################
905906
# Reverse engineered sql for PARTITIONS
@@ -1005,7 +1006,8 @@ def _get_resql_for_partitions(self, data, rset, json_resp,
10051006

10061007
# Get Reverse engineered sql for index
10071008
self._get_resql_for_index(did, row['oid'], partition_sql_arr,
1008-
json_resp, schema, table)
1009+
json_resp, schema, table,
1010+
show_default_values)
10091011

10101012
# Get Reverse engineered sql for ROW SECURITY POLICY
10111013
self._get_resql_for_row_security_policy(scid, row['oid'],
@@ -1086,7 +1088,8 @@ def get_reverse_engineered_sql(self, **kwargs):
10861088
return internal_server_error(errormsg=rset)
10871089

10881090
self._get_resql_for_partitions(data, rset, json_resp,
1089-
diff_partition_sql, main_sql, did)
1091+
diff_partition_sql, main_sql, did,
1092+
show_default_values)
10901093

10911094
sql = '\n'.join(main_sql)
10921095

0 commit comments

Comments
 (0)