fix: Bump runtime dependencies and upgrade ESLint to v10 (#9834)

- electron: 41.0.2 → 41.2.0
- eslint: ^9.39.2 → ^10.2.0
- axios: ^1.13.5 → ^1.15.0
- electron-context-menu: ^4.1.0 → ^4.1.2
- Added @eslint/js and globals as explicit devDependencies (required by ESLint 10)
- Fixed no-useless-assignment lint errors in downloader.js and misc.js

Author: asheshv

runtime/package.json

@@ -12,13 +12,15 @@
   },
   "packageManager": "yarn@4.9.2",
   "devDependencies": {
-    "electron": "41.0.2",
-    "eslint": "^9.39.2",
-    "eslint-plugin-unused-imports": "^4.4.1"
+    "@eslint/js": "^10.0.1",
+    "electron": "41.2.0",
+    "eslint": "^10.2.0",
+    "eslint-plugin-unused-imports": "^4.4.1",
+    "globals": "^17.4.0"
   },
   "dependencies": {
-    "axios": "^1.13.5",
-    "electron-context-menu": "^4.1.0",
+    "axios": "^1.15.0",
+    "electron-context-menu": "^4.1.2",
     "electron-store": "^11.0.2"
   }
 }

runtime/src/js/downloader.js

@@ -47,7 +47,7 @@ function updateProgress(callerWindow) {
     return;
   }
   setBadge(Object.keys(downloadQueue).length);
-  let progress = 0;
+  let progress;
   if(Object.values(downloadQueue).some((item) => item.total === null)) {
     // If any of the items in the queue does not have a total, we cannot calculate progress
     // so we return 2 to indicate that the progress is indeterminate.

runtime/src/js/misc.js

@@ -100,17 +100,13 @@ const serverLogFile = path.join(getLocalAppDataPath(), 'pgadmin4.' + (new Date()
 
 // This function is used to read the file and return the content
 export const readServerLog = () => {
-  let data = null;
-
   if (fs.existsSync(serverLogFile)) {
-    data = fs.readFileSync(serverLogFile, 'utf8');
-  } else {
-    let errMsg = 'Unable to read file ' + serverLogFile + '.';
-    console.warn(errMsg);
-    return errMsg;
+    return fs.readFileSync(serverLogFile, 'utf8');
   }
 
-  return data;
+  let errMsg = 'Unable to read file ' + serverLogFile + '.';
+  console.warn(errMsg);
+  return errMsg;
 };
 
 // This function is used to write the data into the log file